[v1,1/1] ASoC: rsnd: fixup mod ID calculation in rsnd_ctu_probe_
diff mbox series

Message ID 20190618025749.12505-1-jiada_wang@mentor.com
State Superseded
Headers show
Series
  • [v1,1/1] ASoC: rsnd: fixup mod ID calculation in rsnd_ctu_probe_
Related show

Commit Message

Jiada Wang June 18, 2019, 2:57 a.m. UTC
From: Nilkanth Ahirrao <anilkanth@jp.adit-jv.com>

commit 7e4f3419ebfe ("ASoC: rsnd: add .get_id/.get_id_sub")
introduces rsnd_ctu_id which calcualates and gives
the main Device id of the CTU by dividing the id by 4.
rsnd_mod_id uses this interface to get the CTU main
Device id. But this commit forgets to revert the main
Device id calcution previously done in rsnd_ctu_probe_
which also divides the id by 4. This path corrects the
same to get the correct main Device id.

The issue is observered when rsnd_ctu_probe_ is done for CTU1

Fixes: 7e4f3419ebfe ("ASoC: rsnd: add .get_id/.get_id_sub")

Signed-off-by: Nilkanth Ahirrao <anilkanth@jp.adit-jv.com>
Signed-off-by: Suresh Udipi <sudipi@jp.adit-jv.com>
Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
---
 sound/soc/sh/rcar/ctu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kuninori Morimoto June 18, 2019, 3:57 a.m. UTC | #1
Hi Jiada

> From: Nilkanth Ahirrao <anilkanth@jp.adit-jv.com>
> 
> commit 7e4f3419ebfe ("ASoC: rsnd: add .get_id/.get_id_sub")
> introduces rsnd_ctu_id which calcualates and gives
> the main Device id of the CTU by dividing the id by 4.
> rsnd_mod_id uses this interface to get the CTU main
> Device id. But this commit forgets to revert the main
> Device id calcution previously done in rsnd_ctu_probe_
> which also divides the id by 4. This path corrects the
> same to get the correct main Device id.
> 
> The issue is observered when rsnd_ctu_probe_ is done for CTU1
> 
> Fixes: 7e4f3419ebfe ("ASoC: rsnd: add .get_id/.get_id_sub")
> 
> Signed-off-by: Nilkanth Ahirrao <anilkanth@jp.adit-jv.com>
> Signed-off-by: Suresh Udipi <sudipi@jp.adit-jv.com>
> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
> ---

Thanks !!

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

But, I guess commit ID is this for upstream ?

c16015f36cc128244c910152663de45c3b99f551
("ASoC: rsnd: add .get_id/.get_id_sub")

>  sound/soc/sh/rcar/ctu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/sh/rcar/ctu.c b/sound/soc/sh/rcar/ctu.c
> index 8cb06dab234e..7647b3d4c0ba 100644
> --- a/sound/soc/sh/rcar/ctu.c
> +++ b/sound/soc/sh/rcar/ctu.c
> @@ -108,7 +108,7 @@ static int rsnd_ctu_probe_(struct rsnd_mod *mod,
>  			   struct rsnd_dai_stream *io,
>  			   struct rsnd_priv *priv)
>  {
> -	return rsnd_cmd_attach(io, rsnd_mod_id(mod) / 4);
> +	return rsnd_cmd_attach(io, rsnd_mod_id(mod));
>  }
>  
>  static void rsnd_ctu_value_init(struct rsnd_dai_stream *io,
> -- 
> 2.19.2
>

Patch
diff mbox series

diff --git a/sound/soc/sh/rcar/ctu.c b/sound/soc/sh/rcar/ctu.c
index 8cb06dab234e..7647b3d4c0ba 100644
--- a/sound/soc/sh/rcar/ctu.c
+++ b/sound/soc/sh/rcar/ctu.c
@@ -108,7 +108,7 @@  static int rsnd_ctu_probe_(struct rsnd_mod *mod,
 			   struct rsnd_dai_stream *io,
 			   struct rsnd_priv *priv)
 {
-	return rsnd_cmd_attach(io, rsnd_mod_id(mod) / 4);
+	return rsnd_cmd_attach(io, rsnd_mod_id(mod));
 }
 
 static void rsnd_ctu_value_init(struct rsnd_dai_stream *io,