[1/4] dt-bindings: iio: frequency: Use dt-schema for clock-names
diff mbox series

Message ID 1561389097-26075-1-git-send-email-stefan.popa@analog.com
State New
Headers show
Series
  • [1/4] dt-bindings: iio: frequency: Use dt-schema for clock-names
Related show

Commit Message

Stefan Popa June 24, 2019, 3:11 p.m. UTC
Dt-schema can be used for clock-names property.

Signed-off-by: Stefan Popa <stefan.popa@analog.com>
---
 Documentation/devicetree/bindings/iio/frequency/adf4371.yaml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Maxime Ripard June 25, 2019, 8:30 a.m. UTC | #1
Hi,

On Mon, Jun 24, 2019 at 06:11:37PM +0300, Stefan Popa wrote:
> Dt-schema can be used for clock-names property.
>
> Signed-off-by: Stefan Popa <stefan.popa@analog.com>
> ---
>  Documentation/devicetree/bindings/iio/frequency/adf4371.yaml | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> index d7adf074..8a2a8f6 100644
> --- a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> +++ b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> @@ -27,9 +27,8 @@ properties:
>      maxItems: 1
>
>    clock-names:
> -    description:
> -      Must be "clkin"
> -    maxItems: 1
> +    items:
> +      - clkin

You can even just have const: clkin here

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Jonathan Cameron June 26, 2019, 7:42 p.m. UTC | #2
On Tue, 25 Jun 2019 10:30:36 +0200
Maxime Ripard <maxime.ripard@bootlin.com> wrote:

> Hi,
> 
> On Mon, Jun 24, 2019 at 06:11:37PM +0300, Stefan Popa wrote:
> > Dt-schema can be used for clock-names property.
> >
> > Signed-off-by: Stefan Popa <stefan.popa@analog.com>
> > ---
> >  Documentation/devicetree/bindings/iio/frequency/adf4371.yaml | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> > index d7adf074..8a2a8f6 100644
> > --- a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> > +++ b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> > @@ -27,9 +27,8 @@ properties:
> >      maxItems: 1
> >
> >    clock-names:
> > -    description:
> > -      Must be "clkin"
> > -    maxItems: 1
> > +    items:
> > +      - clkin  
> 
> You can even just have const: clkin here
> 
Given this is fairly independent from the rest of the series, I'll plough
on with the others and expect a v2 of this one to address Maxime's
suggestion.

Thanks,

Jonathan

> Maxime
> 
> --
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
index d7adf074..8a2a8f6 100644
--- a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
+++ b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
@@ -27,9 +27,8 @@  properties:
     maxItems: 1
 
   clock-names:
-    description:
-      Must be "clkin"
-    maxItems: 1
+    items:
+      - clkin
 
 required:
   - compatible