From: Saravana Kannan <saravanak@google.com>
To: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Frank Rowand <frowand.list@gmail.com>
Cc: Saravana Kannan <saravanak@google.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
David Collins <collinsd@codeaurora.org>,
kernel-team@android.com
Subject: [PATCH v4 7/8] of/platform: Sanity check DT bindings before creating device links
Date: Mon, 8 Jul 2019 15:56:23 -0700 [thread overview]
Message-ID: <20190708225624.119973-8-saravanak@google.com> (raw)
In-Reply-To: <20190708225624.119973-1-saravanak@google.com>
If a common DT binding is pointing to a child DT node of a particular
parent DT node, don't add device links for such DT references. This is
because, by definition, a child node can't be a functional dependency for
the parent node.
Signed-off-by: Saravana Kannan <saravanak@google.com>
---
drivers/of/platform.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/of/platform.c b/drivers/of/platform.c
index dba962a0ee50..98414ba53b1f 100644
--- a/drivers/of/platform.c
+++ b/drivers/of/platform.c
@@ -512,6 +512,19 @@ int of_platform_default_populate(struct device_node *root,
}
EXPORT_SYMBOL_GPL(of_platform_default_populate);
+bool of_link_is_valid(struct device_node *con, struct device_node *sup)
+{
+ of_node_get(sup);
+ while (sup) {
+ if (sup == con) {
+ of_node_put(sup);
+ return false;
+ }
+ sup = of_get_next_parent(sup);
+ }
+ return true;
+}
+
static int of_link_binding(struct device *dev,
const char *binding, const char *cell)
{
@@ -522,6 +535,10 @@ static int of_link_binding(struct device *dev,
while (!of_parse_phandle_with_args(dev->of_node, binding, cell, i,
&sup_args)) {
+ if (!of_link_is_valid(dev->of_node, sup_args.np)) {
+ of_node_put(sup_args.np);
+ continue;
+ }
i++;
sup_dev = of_find_device_by_node(sup_args.np);
of_node_put(sup_args.np);
--
2.22.0.410.gd8fdbe21b5-goog
next prev parent reply other threads:[~2019-07-08 22:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 22:56 [PATCH v4 0/8] Solve postboot supplier cleanup and optimize probe ordering Saravana Kannan
2019-07-08 22:56 ` [PATCH v4 1/8] driver core: Add support for linking devices during device addition Saravana Kannan
2019-07-08 22:56 ` [PATCH v4 2/8] of/platform: Add functional dependency link from DT bindings Saravana Kannan
2019-07-08 22:56 ` [PATCH v4 3/8] driver core: Add sync_state driver/bus callback Saravana Kannan
2019-07-08 22:56 ` [PATCH v4 4/8] driver core: Add edit_links() callback for drivers Saravana Kannan
2019-07-08 22:56 ` [PATCH v4 5/8] driver core: Add APIs to pause/resume sync state callbacks Saravana Kannan
2019-07-08 22:56 ` [PATCH v4 6/8] of/platform: Pause/resume sync state in of_platform_populate() Saravana Kannan
2019-07-08 22:56 ` Saravana Kannan [this message]
2019-07-08 22:56 ` [PATCH v4 8/8] of/platform: Create device links for all child-supplier depencencies Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190708225624.119973-8-saravanak@google.com \
--to=saravanak@google.com \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).