From: Hariprasad Kelam <hariprasad.kelam@gmail.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Vinod Koul <vkoul@kernel.org>, Wen Yang <wen.yang99@zte.com.cn>,
Gen Zhang <blackgod016574@gmail.com>,
Hariprasad Kelam <hariprasad.kelam@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: [PATCH] sound: soc: codecs: wcd9335: fix "conversion to bool not needed here"
Date: Thu, 11 Jul 2019 23:19:06 +0530 [thread overview]
Message-ID: <20190711174906.GA10867@hari-Inspiron-1545> (raw)
Fix below issue reported by coccicheck
sound/soc/codecs/wcd9335.c:3991:25-30: WARNING: conversion to bool not
needed here
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
sound/soc/codecs/wcd9335.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c
index 1bbbe42..85a8d10 100644
--- a/sound/soc/codecs/wcd9335.c
+++ b/sound/soc/codecs/wcd9335.c
@@ -3988,12 +3988,7 @@ static irqreturn_t wcd9335_slimbus_irq(int irq, void *data)
regmap_read(wcd->if_regmap,
WCD9335_SLIM_PGD_PORT_INT_RX_SOURCE0 + j, &val);
if (val) {
- if (!tx)
- reg = WCD9335_SLIM_PGD_PORT_INT_EN0 +
- (port_id / 8);
- else
- reg = WCD9335_SLIM_PGD_PORT_INT_TX_EN0 +
- (port_id / 8);
+ reg = WCD9335_SLIM_PGD_PORT_INT_TX_EN0 + (port_id / 8);
regmap_read(
wcd->if_regmap, reg, &int_val);
/*
--
2.7.4
next reply other threads:[~2019-07-11 17:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 17:49 Hariprasad Kelam [this message]
2019-07-11 22:00 ` [PATCH] sound: soc: codecs: wcd9335: fix "conversion to bool not needed here" Joe Perches
2019-07-13 13:46 ` Hariprasad Kelam
2019-07-13 13:50 ` Hariprasad Kelam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190711174906.GA10867@hari-Inspiron-1545 \
--to=hariprasad.kelam@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=blackgod016574@gmail.com \
--cc=broonie@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).