linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Saravana Kannan <saravanak@google.com>
To: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>
Cc: Saravana Kannan <saravanak@google.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	David Collins <collinsd@codeaurora.org>,
	kernel-team@android.com
Subject: [PATCH v5 06/11] of/platform: Pause/resume sync state in of_platform_populate()
Date: Fri, 12 Jul 2019 16:52:39 -0700	[thread overview]
Message-ID: <20190712235245.202558-7-saravanak@google.com> (raw)
In-Reply-To: <20190712235245.202558-1-saravanak@google.com>

When multiple child devices are populated using of_platform_populate()
after kernel init, there could be supplier-consumer dependencies between
the child devices.

Wait for all the devices to be added and linked before calling sync_state()
on all the suppliers.

Signed-off-by: Saravana Kannan <saravanak@google.com>
---
 drivers/of/platform.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/of/platform.c b/drivers/of/platform.c
index 56b718f09929..dba962a0ee50 100644
--- a/drivers/of/platform.c
+++ b/drivers/of/platform.c
@@ -486,6 +486,7 @@ int of_platform_populate(struct device_node *root,
 	pr_debug("%s()\n", __func__);
 	pr_debug(" starting at: %pOF\n", root);
 
+	device_links_supplier_sync_state_pause();
 	for_each_child_of_node(root, child) {
 		rc = of_platform_bus_create(child, matches, lookup, parent, true);
 		if (rc) {
@@ -493,6 +494,8 @@ int of_platform_populate(struct device_node *root,
 			break;
 		}
 	}
+	device_links_supplier_sync_state_resume();
+
 	of_node_set_flag(root, OF_POPULATED_BUS);
 
 	of_node_put(root);
-- 
2.22.0.510.g264f2c817a-goog


  parent reply	other threads:[~2019-07-12 23:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-12 23:52 [PATCH v5 00/11] Solve postboot supplier cleanup and optimize probe ordering Saravana Kannan
2019-07-12 23:52 ` [PATCH v5 01/11] driver core: Add support for linking devices during device addition Saravana Kannan
2019-07-12 23:52 ` [PATCH v5 02/11] of/platform: Add functional dependency link from DT bindings Saravana Kannan
2019-07-16 23:43   ` Rob Herring
2019-07-16 23:53     ` Saravana Kannan
2019-07-17 14:35       ` Rob Herring
2019-07-17 20:38         ` Saravana Kannan
2019-07-12 23:52 ` [PATCH v5 03/11] driver core: Add sync_state driver/bus callback Saravana Kannan
2019-07-12 23:52 ` [PATCH v5 04/11] driver core: Add edit_links() callback for drivers Saravana Kannan
2019-07-12 23:52 ` [PATCH v5 05/11] driver core: Add APIs to pause/resume sync state callbacks Saravana Kannan
2019-07-12 23:52 ` Saravana Kannan [this message]
2019-07-12 23:52 ` [PATCH v5 07/11] of/platform: Sanity check DT bindings before creating device links Saravana Kannan
2019-07-12 23:52 ` [PATCH v5 08/11] of/platform: Make sure supplier DT node is device when " Saravana Kannan
2019-07-12 23:52 ` [PATCH v5 09/11] of/platform: Create device links for all child-supplier depencencies Saravana Kannan
2019-07-12 23:52 ` [PATCH v5 10/11] of/platform: Add functional dependency link from DT regulator bindings Saravana Kannan
2019-07-12 23:52 ` [PATCH v5 11/11] of/platform: Don't create device links default busses Saravana Kannan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190712235245.202558-7-saravanak@google.com \
    --to=saravanak@google.com \
    --cc=collinsd@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=rafael@kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).