[GIT,PULL] Modules updates for v5.3
mbox series

Message ID 20190718113346.GA19574@linux-8ccs
State New
Headers show
Series
  • [GIT,PULL] Modules updates for v5.3
Related show

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/jeyu/linux.git tags/modules-for-v5.3

Message

Jessica Yu July 18, 2019, 11:33 a.m. UTC
Hi Linus,

Please pull below to receive modules updates for the 5.3 merge window.
Details can be found in the signed tag.

Thanks!

Jessica

---
The following changes since commit cd6c84d8f0cdc911df435bb075ba22ce3c605b07:

  Linux 5.2-rc2 (2019-05-26 16:49:19 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/jeyu/linux.git tags/modules-for-v5.3

for you to fetch changes up to 93651f80dcb616b8c9115cdafc8e57a781af22d0:

  modules: fix compile error if don't have strict module rwx (2019-06-26 19:27:59 +0200)

----------------------------------------------------------------
Modules updates for v5.3

Summary of modules changes for the 5.3 merge window:

- Code fixes and cleanups

- Fix bug where set_memory_x() wasn't being called when rodata=n

- Fix bug where -EEXIST was being returned for going modules

- Allow arches to override module_exit_section()

Signed-off-by: Jessica Yu <jeyu@kernel.org>

----------------------------------------------------------------
Gustavo A. R. Silva (1):
      kernel: module: Use struct_size() helper

Matthias Schiffer (2):
      module: allow arch overrides for .exit section names
      ARM: module: recognize unwind exit sections

Prarit Bhargava (1):
      kernel/module.c: Only return -EEXIST for modules that have finished loading

Yang Yingliang (2):
      modules: fix BUG when load module with rodata=n
      modules: fix compile error if don't have strict module rwx

YueHaibing (1):
      kernel/module: Fix mem leak in module_add_modinfo_attrs

 arch/arm/kernel/module.c     |  7 ++++++
 include/linux/moduleloader.h |  5 ++++
 kernel/module.c              | 60 ++++++++++++++++++++++++++++++--------------
 3 files changed, 53 insertions(+), 19 deletions(-)

Comments

Linus Torvalds July 18, 2019, 7:20 p.m. UTC | #1
On Thu, Jul 18, 2019 at 4:33 AM Jessica Yu <jeyu@kernel.org> wrote:
>
> Modules updates for v5.3
>
> - Fix bug where -EEXIST was being returned for going modules

Hmm.

I have pulled this, but this change makes me a bit nervous.

I have this dim memory of us having deadlocks in module loading
because module loading triggered other modules to be loaded, and we
had circular dependencies..

This is from years and years ago (that whole state check is not
recent), so my memory may simply be wrong, but I thought I'd mention
it...

                   Linus
pr-tracker-bot@kernel.org July 18, 2019, 7:25 p.m. UTC | #2
The pull request you sent on Thu, 18 Jul 2019 13:33:49 +0200:

> git://git.kernel.org/pub/scm/linux/kernel/git/jeyu/linux.git tags/modules-for-v5.3

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/da0acd7c656c09b362b5095dc8595f8655dc1223

Thank you!
Prarit Bhargava July 19, 2019, 11:38 a.m. UTC | #3
On 7/18/19 3:20 PM, Linus Torvalds wrote:
> On Thu, Jul 18, 2019 at 4:33 AM Jessica Yu <jeyu@kernel.org> wrote:
>>
>> Modules updates for v5.3
>>
>> - Fix bug where -EEXIST was being returned for going modules
> 
> Hmm.
> 
> I have pulled this, but this change makes me a bit nervous.
> 
> I have this dim memory of us having deadlocks in module loading
> because module loading triggered other modules to be loaded, and we
> had circular dependencies..
> 

Interesting.  I'll try to search around to see if I can find the thread.

P.

> This is from years and years ago (that whole state check is not
> recent), so my memory may simply be wrong, but I thought I'd mention
> it...
> 
>                    Linus
>