linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: linux-kbuild@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>, Christoph Hellwig <hch@lst.de>,
	"Darrick J . Wong" <darrick.wong@oracle.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Sam Ravnborg <sam@ravnborg.org>,
	Jani Nikula <jani.nikula@intel.com>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] kbuild: disable compile-test of kernel headers for now
Date: Fri, 19 Jul 2019 19:08:59 +0900	[thread overview]
Message-ID: <20190719100859.11227-1-yamada.masahiro@socionext.com> (raw)

This compile-test started from the strong belief that (almost) all
headers should be able to be compiled as a standalone unit, but this
requirement seems to be just annoying.

I believe compile-test of exported headers is good. On the other hand,
in-kernel headers are not necessarily supposed to be always compilable.
Actually, some headers are only included under a certain combination
of CONFIG options, and that is definitely fine.

This test is still causing false positive errors in randconfig.
Moreover, newly added headers are compile-tested by default, sometimes
they catch (not fatal) bugs, but often raise false positive errors to
end up with making people upset.

The merge window is closing shortly, so there is not much I can do.
Disable it for now, and take a pause to re-think whether we should
continue this or change the course.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 init/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/init/Kconfig b/init/Kconfig
index 9697c6b5303c..778551a1a13c 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -111,6 +111,7 @@ config HEADER_TEST
 config KERNEL_HEADER_TEST
 	bool "Compile test kernel headers"
 	depends on HEADER_TEST
+	depends on BROKEN	# disabled for now
 	help
 	  Headers in include/ are used to build external moduls.
 	  Compile test them to ensure they are self-contained, i.e.
-- 
2.17.1


             reply	other threads:[~2019-07-19 10:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-19 10:08 Masahiro Yamada [this message]
2019-07-19 10:13 ` [PATCH] kbuild: disable compile-test of kernel headers for now Arnd Bergmann
2019-07-19 12:40 ` Sam Ravnborg
2019-07-22  4:49   ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190719100859.11227-1-yamada.masahiro@socionext.com \
    --to=yamada.masahiro@socionext.com \
    --cc=arnd@arndb.de \
    --cc=darrick.wong@oracle.com \
    --cc=hch@lst.de \
    --cc=jani.nikula@intel.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).