linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Jordan <daniel.m.jordan@oracle.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
	Steffen Klassert <steffen.klassert@secunet.com>
Cc: Daniel Jordan <daniel.m.jordan@oracle.com>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] padata: purge get_cpu and reorder_via_wq from padata_do_serial
Date: Fri, 19 Jul 2019 15:04:44 -0400	[thread overview]
Message-ID: <20190719190444.15143-1-daniel.m.jordan@oracle.com> (raw)
In-Reply-To: <20190719145546.hkpe77mevab3gzwq@gondor.apana.org.au>

With the removal of the padata timer, padata_do_serial no longer
needs special CPU handling, so remove it.

Signed-off-by: Daniel Jordan <daniel.m.jordan@oracle.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Steffen Klassert <steffen.klassert@secunet.com>
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
 kernel/padata.c | 23 +++--------------------
 1 file changed, 3 insertions(+), 20 deletions(-)

diff --git a/kernel/padata.c b/kernel/padata.c
index fbafca18597f..7372fb45eeeb 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -316,24 +316,9 @@ static void padata_serial_worker(struct work_struct *serial_work)
  */
 void padata_do_serial(struct padata_priv *padata)
 {
-	int cpu;
-	struct padata_parallel_queue *pqueue;
-	struct parallel_data *pd;
-	int reorder_via_wq = 0;
-
-	pd = padata->pd;
-
-	cpu = get_cpu();
-
-	/* We need to enqueue the padata object into the correct
-	 * per-cpu queue.
-	 */
-	if (cpu != padata->cpu) {
-		reorder_via_wq = 1;
-		cpu = padata->cpu;
-	}
-
-	pqueue = per_cpu_ptr(pd->pqueue, cpu);
+	struct parallel_data *pd = padata->pd;
+	struct padata_parallel_queue *pqueue = per_cpu_ptr(pd->pqueue,
+							   padata->cpu);
 
 	spin_lock(&pqueue->reorder.lock);
 	list_add_tail(&padata->list, &pqueue->reorder.list);
@@ -347,8 +332,6 @@ void padata_do_serial(struct padata_priv *padata)
 	 */
 	smp_mb__after_atomic();
 
-	put_cpu();
-
 	padata_reorder(pd);
 }
 EXPORT_SYMBOL(padata_do_serial);
-- 
2.22.0


  reply	other threads:[~2019-07-19 19:05 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-11 22:12 [PATCH] padata: use smp_mb in padata_reorder to avoid orphaned padata jobs Daniel Jordan
2019-07-12 10:06 ` Herbert Xu
2019-07-12 10:10   ` Steffen Klassert
2019-07-12 16:07     ` Daniel Jordan
2019-07-13  5:03       ` Herbert Xu
2019-07-15 16:10         ` Daniel Jordan
2019-07-16 10:04           ` Herbert Xu
2019-07-16 11:14             ` Steffen Klassert
2019-07-16 12:57               ` [PATCH] padata: Use RCU when fetching pd from do_serial Herbert Xu
2019-07-16 13:09                 ` Herbert Xu
2019-07-16 13:23                   ` [v2 PATCH] " Herbert Xu
2019-07-17  8:36                     ` Steffen Klassert
2019-07-17  8:50                       ` Herbert Xu
2019-07-17  8:28                   ` [PATCH] " Steffen Klassert
2019-07-17  8:47                     ` Herbert Xu
2019-07-17  8:53                       ` Steffen Klassert
2019-07-16 13:15                 ` Peter Zijlstra
2019-07-16 13:18                   ` Herbert Xu
2019-07-16 13:50                     ` Peter Zijlstra
2019-07-16 13:52                       ` Herbert Xu
2019-07-16 12:53       ` [PATCH] padata: use smp_mb in padata_reorder to avoid orphaned padata jobs Andrea Parri
2019-07-16 13:13         ` Peter Zijlstra
2019-07-16 15:01         ` Herbert Xu
2019-07-16 15:44           ` Daniel Jordan
2019-07-16 16:32             ` [PATCH v2] " Daniel Jordan
2019-07-17 11:11               ` [PATCH] padata: Replace delayed timer with immediate workqueue in padata_reorder Herbert Xu
2019-07-17 18:32                 ` Daniel Jordan
2019-07-18  3:31                   ` Herbert Xu
2019-07-18 14:27                     ` Daniel Jordan
2019-07-18 14:56                       ` Herbert Xu
2019-07-18 15:01                         ` [v2 PATCH] " Herbert Xu
2019-07-19 14:37                           ` Daniel Jordan
2019-07-19 14:55                             ` Herbert Xu
2019-07-19 19:04                               ` Daniel Jordan [this message]
2019-07-26 12:36                                 ` [PATCH] padata: purge get_cpu and reorder_via_wq from padata_do_serial Herbert Xu
2019-07-19 14:27                         ` [PATCH] padata: Replace delayed timer with immediate workqueue in padata_reorder Daniel Jordan
2019-07-17 23:21                 ` Daniel Jordan
2019-07-18  3:30                   ` Herbert Xu
2019-07-18 14:25                     ` Daniel Jordan
2019-07-18 14:49                       ` Herbert Xu
2019-07-19 14:21                         ` Daniel Jordan
2019-07-18  5:42               ` [PATCH v2] padata: use smp_mb in padata_reorder to avoid orphaned padata jobs Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190719190444.15143-1-daniel.m.jordan@oracle.com \
    --to=daniel.m.jordan@oracle.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).