From: "George G. Davis" <george_davis@mentor.com>
To: Russell King <linux@armlinux.org.uk>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Thomas Gleixner <tglx@linutronix.de>,
Florian Fainelli <f.fainelli@gmail.com>,
Allison Randal <allison@lohutok.net>,
"George G. Davis" <george_davis@mentor.com>,
Souptick Joarder <jrdr.linux@gmail.com>,
"moderated list:ARM PORT" <linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: [PATCH] ARM: Fix null die() string for unhandled data and prefetch abort cases
Date: Fri, 19 Jul 2019 22:32:55 -0400 [thread overview]
Message-ID: <1563589976-19004-1-git-send-email-george_davis@mentor.com> (raw)
When an unhandled data or prefetch abort occurs, the die() string
is empty resulting in backtrace messages similar to the following:
Internal error: : 1 [#1] PREEMPT SMP ARM
Replace the null string with the name of the abort handler in order
to provide more meaningful hints as to the cause of the fault.
Signed-off-by: George G. Davis <george_davis@mentor.com>
---
arch/arm/mm/fault.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mm/fault.c b/arch/arm/mm/fault.c
index 0048eadd0681..dddea0a21220 100644
--- a/arch/arm/mm/fault.c
+++ b/arch/arm/mm/fault.c
@@ -557,7 +557,7 @@ do_DataAbort(unsigned long addr, unsigned int fsr, struct pt_regs *regs)
inf->name, fsr, addr);
show_pte(current->mm, addr);
- arm_notify_die("", regs, inf->sig, inf->code, (void __user *)addr,
+ arm_notify_die(inf->name, regs, inf->sig, inf->code, (void __user *)addr,
fsr, 0);
}
@@ -585,7 +585,7 @@ do_PrefetchAbort(unsigned long addr, unsigned int ifsr, struct pt_regs *regs)
pr_alert("Unhandled prefetch abort: %s (0x%03x) at 0x%08lx\n",
inf->name, ifsr, addr);
- arm_notify_die("", regs, inf->sig, inf->code, (void __user *)addr,
+ arm_notify_die(inf->name, regs, inf->sig, inf->code, (void __user *)addr,
ifsr, 0);
}
--
2.7.4
next reply other threads:[~2019-07-20 2:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-20 2:32 George G. Davis [this message]
2019-07-20 12:30 ` [PATCH] ARM: Fix null die() string for unhandled data and prefetch abort cases Russell King - ARM Linux admin
2019-07-25 21:37 ` George G. Davis
2019-07-25 21:55 ` Russell King - ARM Linux admin
2019-07-25 22:24 ` George G. Davis
2019-07-25 22:32 ` Russell King - ARM Linux admin
2019-07-25 23:15 ` George G. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1563589976-19004-1-git-send-email-george_davis@mentor.com \
--to=george_davis@mentor.com \
--cc=allison@lohutok.net \
--cc=ebiederm@xmission.com \
--cc=f.fainelli@gmail.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).