platform/x86/pcengines-apuv2: use KEY_RESTART for front button
diff mbox series

Message ID 1563795379-7521-1-git-send-email-info@metux.net
State Superseded
Headers show
Series
  • platform/x86/pcengines-apuv2: use KEY_RESTART for front button
Related show

Commit Message

Enrico Weigelt, metux IT consult July 22, 2019, 11:36 a.m. UTC
From: Enrico Weigelt <info@metux.net>

The keycode KEY_RESTART is more appropriate for the front button,
as most people use it for things like restart or factory reset.

Signed-off-by: Enrico Weigelt <info@metux.net>
---
 drivers/platform/x86/pcengines-apuv2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andy Shevchenko July 25, 2019, 5:17 p.m. UTC | #1
On Mon, Jul 22, 2019 at 2:36 PM Enrico Weigelt, metux IT consult
<info@metux.net> wrote:
>
> From: Enrico Weigelt <info@metux.net>
>
> The keycode KEY_RESTART is more appropriate for the front button,
> as most people use it for things like restart or factory reset.
>

Should it go as Fixes?

> Signed-off-by: Enrico Weigelt <info@metux.net>
> ---
>  drivers/platform/x86/pcengines-apuv2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c
> index b0d3110..4138007c 100644
> --- a/drivers/platform/x86/pcengines-apuv2.c
> +++ b/drivers/platform/x86/pcengines-apuv2.c
> @@ -93,7 +93,7 @@
>
>  static struct gpio_keys_button apu2_keys_buttons[] = {
>         {
> -               .code                   = KEY_SETUP,
> +               .code                   = KEY_RESTART,
>                 .active_low             = 1,
>                 .desc                   = "front button",
>                 .type                   = EV_KEY,
> --
> 1.9.1
>
Enrico Weigelt, metux IT consult July 25, 2019, 6:50 p.m. UTC | #2
On 25.07.19 19:17, Andy Shevchenko wrote:
> On Mon, Jul 22, 2019 at 2:36 PM Enrico Weigelt, metux IT consult
> <info@metux.net> wrote:
>>
>> From: Enrico Weigelt <info@metux.net>
>>
>> The keycode KEY_RESTART is more appropriate for the front button,
>> as most people use it for things like restart or factory reset.
>>
> 
> Should it go as Fixes?

I think so. Technically, the feature already worked, but the keycode
wasn't semantically fine.

--mtx
Andy Shevchenko July 25, 2019, 6:57 p.m. UTC | #3
On Thu, Jul 25, 2019 at 9:50 PM Enrico Weigelt, metux IT consult
<lkml@metux.net> wrote:
>
> On 25.07.19 19:17, Andy Shevchenko wrote:
> > On Mon, Jul 22, 2019 at 2:36 PM Enrico Weigelt, metux IT consult
> > <info@metux.net> wrote:
> >>
> >> From: Enrico Weigelt <info@metux.net>
> >>
> >> The keycode KEY_RESTART is more appropriate for the front button,
> >> as most people use it for things like restart or factory reset.
> >>
> >
> > Should it go as Fixes?
>
> I think so. Technically, the feature already worked, but the keycode
> wasn't semantically fine.

Can you provide a Fixes tag?
Enrico Weigelt, metux IT consult July 25, 2019, 7:06 p.m. UTC | #4
On 25.07.19 20:57, Andy Shevchenko wrote:
> On Thu, Jul 25, 2019 at 9:50 PM Enrico Weigelt, metux IT consult
> <lkml@metux.net> wrote:
>>
>> On 25.07.19 19:17, Andy Shevchenko wrote:
>>> On Mon, Jul 22, 2019 at 2:36 PM Enrico Weigelt, metux IT consult
>>> <info@metux.net> wrote:
>>>>
>>>> From: Enrico Weigelt <info@metux.net>
>>>>
>>>> The keycode KEY_RESTART is more appropriate for the front button,
>>>> as most people use it for things like restart or factory reset.
>>>>
>>>
>>> Should it go as Fixes?
>>
>> I think so. Technically, the feature already worked, but the keycode
>> wasn't semantically fine.
> 
> Can you provide a Fixes tag?
> 

Okay, sent a v2.

Patch
diff mbox series

diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c
index b0d3110..4138007c 100644
--- a/drivers/platform/x86/pcengines-apuv2.c
+++ b/drivers/platform/x86/pcengines-apuv2.c
@@ -93,7 +93,7 @@ 
 
 static struct gpio_keys_button apu2_keys_buttons[] = {
 	{
-		.code			= KEY_SETUP,
+		.code			= KEY_RESTART,
 		.active_low		= 1,
 		.desc			= "front button",
 		.type			= EV_KEY,