From: YueHaibing <yuehaibing@huawei.com>
To: <sakari.ailus@linux.intel.com>, <mchehab@kernel.org>,
<gregkh@linuxfoundation.org>, <yong.zhi@intel.com>,
<digetx@gmail.com>, <hverkuil-cisco@xs4all.nl>
Cc: <linux-kernel@vger.kernel.org>, <devel@driverdev.osuosl.org>,
<linux-media@vger.kernel.org>, YueHaibing <yuehaibing@huawei.com>
Subject: [PATCH] media: staging: ipu3: Enable IOVA API only when IOMMU support is enabled
Date: Mon, 22 Jul 2019 21:47:49 +0800 [thread overview]
Message-ID: <20190722134749.21580-1-yuehaibing@huawei.com> (raw)
If IOMMU_SUPPORT is not set, ipu3 driver may select IOMMU_IOVA to m.
But for many drivers, they use "select IOMMU_IOVA if IOMMU_SUPPORT"
in the Kconfig, for example, CONFIG_TEGRA_VDE is set to y but IOMMU_IOVA
is m, then the building fails like this:
drivers/staging/media/tegra-vde/iommu.o: In function `tegra_vde_iommu_map':
iommu.c:(.text+0x41): undefined reference to `alloc_iova'
iommu.c:(.text+0x56): undefined reference to `__free_iova'
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 7fc7af649ca7 ("media: staging/intel-ipu3: Add imgu top level pci device driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/staging/media/ipu3/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/ipu3/Kconfig b/drivers/staging/media/ipu3/Kconfig
index 4b51c67..b7df18f 100644
--- a/drivers/staging/media/ipu3/Kconfig
+++ b/drivers/staging/media/ipu3/Kconfig
@@ -4,7 +4,7 @@ config VIDEO_IPU3_IMGU
depends on PCI && VIDEO_V4L2
depends on MEDIA_CONTROLLER && VIDEO_V4L2_SUBDEV_API
depends on X86
- select IOMMU_IOVA
+ select IOMMU_IOVA if IOMMU_SUPPORT
select VIDEOBUF2_DMA_SG
help
This is the Video4Linux2 driver for Intel IPU3 image processing unit,
--
2.7.4
next reply other threads:[~2019-07-22 13:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 13:47 YueHaibing [this message]
2019-07-24 10:30 ` [PATCH] media: staging: ipu3: Enable IOVA API only when IOMMU support is enabled Sakari Ailus
2019-07-24 13:49 ` Robin Murphy
2019-07-24 14:03 ` Yuehaibing
2019-07-24 14:09 ` Dmitry Osipenko
2019-07-24 14:23 ` Robin Murphy
2019-07-24 14:28 ` Dmitry Osipenko
2019-07-25 2:41 ` [PATCH] media: staging: tegra-vde: Fix build error YueHaibing
2019-07-25 7:19 ` Dmitry Osipenko
2019-09-20 19:32 ` Arnd Bergmann
2019-09-20 22:26 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722134749.21580-1-yuehaibing@huawei.com \
--to=yuehaibing@huawei.com \
--cc=devel@driverdev.osuosl.org \
--cc=digetx@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).