[v2] can: dev: call netif_carrier_off() in register_candev()
diff mbox series

Message ID 20190722140429.19782-1-rasmus.villemoes@prevas.dk
State New
Headers show
  • [v2] can: dev: call netif_carrier_off() in register_candev()
Related show

Commit Message

Rasmus Villemoes July 22, 2019, 2:04 p.m. UTC
CONFIG_CAN_LEDS is deprecated. When trying to use the generic netdev
trigger as suggested, there's a small inconsistency with the link
property: The LED is on initially, stays on when the device is brought
up, and then turns off (as expected) when the device is brought down.

Make sure the LED always reflects the state of the CAN device.

Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Acked-by: Willem de Bruijn <willemb@google.com>
v2: resending with proper subject (no net-next) and Willem's ack.

 drivers/net/can/dev.c | 1 +
 1 file changed, 1 insertion(+)

diff mbox series

diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c
index c05e4d50d43d..fad27ace6248 100644
--- a/drivers/net/can/dev.c
+++ b/drivers/net/can/dev.c
@@ -1260,6 +1260,7 @@  int register_candev(struct net_device *dev)
 		return -EINVAL;
 	dev->rtnl_link_ops = &can_link_ops;
+	netif_carrier_off(dev);
 	return register_netdev(dev);