From: Douglas Anderson <dianders@chromium.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>
Cc: David Airlie <airlied@linux.ie>,
linux-fbdev@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
dri-devel@lists.freedesktop.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Russell King <linux@armlinux.org.uk>,
Daniel Vetter <daniel@ffwll.ch>,
Douglas Anderson <dianders@chromium.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 4/4] video: amba-clcd: Spout an error if of_get_display_timing() gives an error
Date: Mon, 22 Jul 2019 11:24:39 -0700 [thread overview]
Message-ID: <20190722182439.44844-5-dianders@chromium.org> (raw)
In-Reply-To: <20190722182439.44844-1-dianders@chromium.org>
In the patch ("video: of: display_timing: Don't yell if no timing node
is present") we'll stop spouting an error directly in
of_get_display_timing() if no node is present. Presumably amba-clcd
should take charge of spouting its own error now.
NOTE: we'll print two errors if the node was present but there were
problems parsing the timing node (one in of_parse_display_timing() and
this new one). Since this is a fatal error for the driver's probe
(and presumably someone will be debugging), this should be OK.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/video/fbdev/amba-clcd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-clcd.c
index 89324e42a033..7de43be6ef2c 100644
--- a/drivers/video/fbdev/amba-clcd.c
+++ b/drivers/video/fbdev/amba-clcd.c
@@ -561,8 +561,10 @@ static int clcdfb_of_get_dpi_panel_mode(struct device_node *node,
struct videomode video;
err = of_get_display_timing(node, "panel-timing", &timing);
- if (err)
+ if (err) {
+ pr_err("%pOF: problems parsing panel-timing (%d)\n", node, err);
return err;
+ }
videomode_from_timing(&timing, &video);
--
2.22.0.657.g960e92d24f-goog
next prev parent reply other threads:[~2019-07-22 18:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 18:24 [PATCH 0/4] video: of: display_timing: Adjust err printing of of_get_display_timing() Douglas Anderson
2019-07-22 18:24 ` [PATCH 1/4] video: of: display_timing: Add of_node_put() in of_get_display_timing() Douglas Anderson
2019-07-27 2:51 ` Laurent Pinchart
2019-07-22 18:24 ` [PATCH 2/4] video: of: display_timing: Don't yell if no timing node is present Douglas Anderson
2019-07-22 18:24 ` [PATCH 3/4] drm: panel-lvds: Spout an error if of_get_display_timing() gives an error Douglas Anderson
2019-07-22 18:24 ` Douglas Anderson [this message]
2019-07-23 8:27 ` [PATCH 4/4] video: amba-clcd: " Linus Walleij
2019-07-23 8:38 ` [PATCH 0/4] video: of: display_timing: Adjust err printing of of_get_display_timing() Sam Ravnborg
2019-07-26 14:42 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722182439.44844-5-dianders@chromium.org \
--to=dianders@chromium.org \
--cc=airlied@linux.ie \
--cc=b.zolnierkie@samsung.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=p.zabel@pengutronix.de \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).