From: stillcompiling@gmail.com
To: Joe Perches <joe@perches.com>, Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org (open list:HID CORE LAYER),
linux-kernel@vger.kernel.org (open list)
Cc: Joshua Clayton <stillcompiling@gmail.com>
Subject: [PATCH v3 1/3] HID: core: reformat and reduce hid_printk macros
Date: Mon, 22 Jul 2019 15:48:25 -0600 [thread overview]
Message-ID: <20190722214827.29257-1-stillcompiling@gmail.com> (raw)
In-Reply-To: <20190722163642.10417-2-stillcompiling@gmail.com>
From: Joshua Clayton <stillcompiling@gmail.com>
Reformat hid_printk macros to use standard __VA_ARGS__ syntax
Remove hid_printk(), hid_emerg(), hid_crit(), and hid_alert().
Per Joe Perches these unused and likely never to be used.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
include/linux/hid.h | 32 ++++++++++++--------------------
1 file changed, 12 insertions(+), 20 deletions(-)
diff --git a/include/linux/hid.h b/include/linux/hid.h
index d770ab1a0479..e6c7efdb0458 100644
--- a/include/linux/hid.h
+++ b/include/linux/hid.h
@@ -1154,29 +1154,21 @@ int hid_pidff_init(struct hid_device *hid);
#define hid_pidff_init NULL
#endif
-#define dbg_hid(format, arg...) \
+#define dbg_hid(fmt, ...) \
do { \
if (hid_debug) \
- printk(KERN_DEBUG "%s: " format, __FILE__, ##arg); \
+ printk(KERN_DEBUG "%s: " fmt, __FILE__, ##__VA_ARGS__); \
} while (0)
-#define hid_printk(level, hid, fmt, arg...) \
- dev_printk(level, &(hid)->dev, fmt, ##arg)
-#define hid_emerg(hid, fmt, arg...) \
- dev_emerg(&(hid)->dev, fmt, ##arg)
-#define hid_crit(hid, fmt, arg...) \
- dev_crit(&(hid)->dev, fmt, ##arg)
-#define hid_alert(hid, fmt, arg...) \
- dev_alert(&(hid)->dev, fmt, ##arg)
-#define hid_err(hid, fmt, arg...) \
- dev_err(&(hid)->dev, fmt, ##arg)
-#define hid_notice(hid, fmt, arg...) \
- dev_notice(&(hid)->dev, fmt, ##arg)
-#define hid_warn(hid, fmt, arg...) \
- dev_warn(&(hid)->dev, fmt, ##arg)
-#define hid_info(hid, fmt, arg...) \
- dev_info(&(hid)->dev, fmt, ##arg)
-#define hid_dbg(hid, fmt, arg...) \
- dev_dbg(&(hid)->dev, fmt, ##arg)
+#define hid_err(hid, fmt, ...) \
+ dev_err(&(hid)->dev, fmt, ##__VA_ARGS__)
+#define hid_notice(hid, fmt, ...) \
+ dev_notice(&(hid)->dev, fmt, ##__VA_ARGS__)
+#define hid_warn(hid, fmt, ...) \
+ dev_warn(&(hid)->dev, fmt, ##__VA_ARGS__)
+#define hid_info(hid, fmt, ...) \
+ dev_info(&(hid)->dev, fmt, ##__VA_ARGS__)
+#define hid_dbg(hid, fmt, ...) \
+ dev_dbg(&(hid)->dev, fmt, ##__VA_ARGS__)
#endif
--
2.21.0
next prev parent reply other threads:[~2019-07-22 21:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 16:36 [PATCH 1/2] HID: core: Add hid printk_once macros stillcompiling
2019-07-22 16:36 ` [PATCH 2/2] HID: core: only warn once of oversize hid report stillcompiling
2019-07-22 17:23 ` Joe Perches
2019-07-22 18:16 ` Joshua Clayton
2019-07-22 21:26 ` [PATCH v2 1/3] HID: core: reformat and reduce hid_printk macros stillcompiling
2019-07-22 21:26 ` [PATCH v2 2/3] HID: core: Add printk_once variants to hid_warn() etc stillcompiling
2019-07-22 21:26 ` [PATCH v2 3/3] HID: core: only warn once of oversize hid report stillcompiling
2019-07-22 21:30 ` Joe Perches
2019-07-22 21:43 ` Joshua Clayton
2019-07-22 21:48 ` stillcompiling [this message]
2019-07-22 21:48 ` [PATCH v3 2/3] HID: core: Add printk_once variants to hid_warn() etc stillcompiling
2019-07-22 21:48 ` [PATCH v3 3/3] HID: core: only warn once of oversize hid report stillcompiling
2019-07-22 17:11 ` [PATCH 1/2] HID: core: Add hid printk_once macros Joe Perches
[not found] <20190812152022.27963-1-stillcompiling@gmail.com>
2019-08-12 15:20 ` [PATCH v3 1/3] HID: core: reformat and reduce hid_printk macros stillcompiling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722214827.29257-1-stillcompiling@gmail.com \
--to=stillcompiling@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=joe@perches.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).