From: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
To: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
axboe@kernel.dk, hare@suse.com
Cc: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Subject: [PATCH 1/2] block: blk-mq: Remove blk_mq_sched_started_request function
Date: Mon, 22 Jul 2019 23:14:38 -0300 [thread overview]
Message-ID: <20190723021439.8419-2-marcos.souza.org@gmail.com> (raw)
In-Reply-To: <20190723021439.8419-1-marcos.souza.org@gmail.com>
This function checks if the elevator related to the request has
started_request implemented, but currently, none of the available IO
schedulers implement started_request.
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
---
block/blk-mq-sched.h | 9 ---------
block/blk-mq.c | 2 --
2 files changed, 11 deletions(-)
diff --git a/block/blk-mq-sched.h b/block/blk-mq-sched.h
index cf22ab00fefb..126021fc3a11 100644
--- a/block/blk-mq-sched.h
+++ b/block/blk-mq-sched.h
@@ -61,15 +61,6 @@ static inline void blk_mq_sched_completed_request(struct request *rq, u64 now)
e->type->ops.completed_request(rq, now);
}
-static inline void blk_mq_sched_started_request(struct request *rq)
-{
- struct request_queue *q = rq->q;
- struct elevator_queue *e = q->elevator;
-
- if (e && e->type->ops.started_request)
- e->type->ops.started_request(rq);
-}
-
static inline void blk_mq_sched_requeue_request(struct request *rq)
{
struct request_queue *q = rq->q;
diff --git a/block/blk-mq.c b/block/blk-mq.c
index b038ec680e84..3e8902714253 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -669,8 +669,6 @@ void blk_mq_start_request(struct request *rq)
{
struct request_queue *q = rq->q;
- blk_mq_sched_started_request(rq);
-
trace_block_rq_issue(q, rq);
if (test_bit(QUEUE_FLAG_STATS, &q->queue_flags)) {
--
2.22.0
next prev parent reply other threads:[~2019-07-23 2:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 2:14 [PATCH 0/2] Remove blk_mq_sched_started_request function Marcos Paulo de Souza
2019-07-23 2:14 ` Marcos Paulo de Souza [this message]
2019-07-23 2:14 ` [PATCH 2/2] include: elevator.h: Remove started_request from elevator_mq_ops Marcos Paulo de Souza
2019-07-23 2:17 ` [PATCH 0/2] Remove blk_mq_sched_started_request function Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723021439.8419-2-marcos.souza.org@gmail.com \
--to=marcos.souza.org@gmail.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).