From: YueHaibing <yuehaibing@huawei.com>
To: <oulijun@huawei.com>, <xavier.huwei@huawei.com>,
<dledford@redhat.com>, <jgg@ziepe.ca>
Cc: <linux-kernel@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
YueHaibing <yuehaibing@huawei.com>
Subject: [PATCH] RDMA/hns: Fix build error for hip08
Date: Tue, 23 Jul 2019 10:49:08 +0800 [thread overview]
Message-ID: <20190723024908.11876-1-yuehaibing@huawei.com> (raw)
If INFINIBAND_HNS_HIP08 is selected and HNS3 is m,
but INFINIBAND_HNS is y, building fails:
drivers/infiniband/hw/hns/hns_roce_hw_v2.o: In function `hns_roce_hw_v2_exit':
hns_roce_hw_v2.c:(.exit.text+0xd): undefined reference to `hnae3_unregister_client'
drivers/infiniband/hw/hns/hns_roce_hw_v2.o: In function `hns_roce_hw_v2_init':
hns_roce_hw_v2.c:(.init.text+0xd): undefined reference to `hnae3_register_client'
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: dd74282df573 ("RDMA/hns: Initialize the PCI device for hip08 RoCE")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/infiniband/hw/hns/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/hns/Kconfig b/drivers/infiniband/hw/hns/Kconfig
index b59da5d..4371c80 100644
--- a/drivers/infiniband/hw/hns/Kconfig
+++ b/drivers/infiniband/hw/hns/Kconfig
@@ -23,7 +23,8 @@ config INFINIBAND_HNS_HIP06
config INFINIBAND_HNS_HIP08
bool "Hisilicon Hip08 Family RoCE support"
- depends on INFINIBAND_HNS && PCI && HNS3
+ depends on INFINIBAND_HNS && (INFINIBAND_HNS = HNS3)
+ depends on PCI
---help---
RoCE driver support for Hisilicon RoCE engine in Hisilicon Hip08 SoC.
The RoCE engine is a PCI device.
--
2.7.4
next reply other threads:[~2019-07-23 2:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 2:49 YueHaibing [this message]
2019-07-23 7:43 ` [PATCH] RDMA/hns: Fix build error for hip08 Leon Romanovsky
2019-07-23 10:06 ` Yuehaibing
2019-07-23 10:17 ` Leon Romanovsky
2019-07-23 12:34 ` Jason Gunthorpe
2019-07-23 13:35 ` Leon Romanovsky
2019-07-23 13:37 ` Jason Gunthorpe
2019-07-24 3:10 ` Yuehaibing
2019-07-24 3:40 ` [PATCH v2] " YueHaibing
2019-07-24 6:12 ` Yuehaibing
2019-07-24 6:54 ` [PATCH] RDMA/hns: Fix build error YueHaibing
2019-07-24 11:32 ` Jason Gunthorpe
2019-07-24 11:47 ` Yuehaibing
2019-07-29 16:05 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723024908.11876-1-yuehaibing@huawei.com \
--to=yuehaibing@huawei.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=oulijun@huawei.com \
--cc=xavier.huwei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).