linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Andy Gross <agross@kernel.org>
Cc: linux-arm-msm@vger.kernel.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Stephen Boyd <swboyd@chromium.org>,
	Amit Kucheria <amit.kucheria@verdurent.com>,
	Marc Gonzalez <marc.w.gonzalez@free.fr>
Subject: [PATCH v2 4/5] arm64: dts: qcom: sdm845: remove macro from unit name
Date: Wed, 24 Jul 2019 10:19:05 +0530	[thread overview]
Message-ID: <20190724044906.12007-5-vkoul@kernel.org> (raw)
In-Reply-To: <20190724044906.12007-1-vkoul@kernel.org>

Unit name is supposed to be a number, using a macro with hex value is
not recommended, so add the value in unit name.

arch/arm64/boot/dts/qcom/pm8998.dtsi:81.18-84.6: Warning (unit_address_format): /soc/spmi@c440000/pmic@0/adc@3100/adc-chan@0x06: unit name should not have leading "0x"
arch/arm64/boot/dts/qcom/pm8998.dtsi:81.18-84.6: Warning (unit_address_format): /soc/spmi@c440000/pmic@0/adc@3100/adc-chan@0x06: unit name should not have leading 0s

Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
 arch/arm64/boot/dts/qcom/pm8998.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
index 051a52df80f9..dc2ce23cde05 100644
--- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
@@ -78,7 +78,7 @@
 			#size-cells = <0>;
 			#io-channel-cells = <1>;
 
-			adc-chan@ADC5_DIE_TEMP {
+			adc-chan@6 {
 				reg = <ADC5_DIE_TEMP>;
 				label = "die_temp";
 			};
-- 
2.20.1


  parent reply	other threads:[~2019-07-24  4:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-24  4:49 [PATCH v2 0/5] arm64: dts: qcom: sdm845: Fix DTS warnings Vinod Koul
2019-07-24  4:49 ` [PATCH v2 1/5] arm64: dts: qcom: sdm845: Add unit name to soc node Vinod Koul
2019-07-24  5:00   ` Amit Kucheria
2019-10-07 17:44   ` John Stultz
2019-10-07 17:57     ` Rob Herring
2019-07-24  4:49 ` [PATCH v2 2/5] arm64: dts: qcom: sdm845: remove unnecessary properties for dsi nodes Vinod Koul
2019-07-24  5:01   ` Amit Kucheria
2019-07-24  4:49 ` [PATCH v2 3/5] arm64: dts: qcom: sdm845: remove unit name for thermal trip points Vinod Koul
2019-07-24  5:20   ` Amit Kucheria
2019-07-24  4:49 ` Vinod Koul [this message]
2019-07-24  5:21   ` [PATCH v2 4/5] arm64: dts: qcom: sdm845: remove macro from unit name Amit Kucheria
2019-07-24 14:11   ` Stephen Boyd
2019-07-24  4:49 ` [PATCH v2 5/5] arm64: dts: qcom: sdm845-cheza: " Vinod Koul
2019-07-24  5:21   ` Amit Kucheria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190724044906.12007-5-vkoul@kernel.org \
    --to=vkoul@kernel.org \
    --cc=agross@kernel.org \
    --cc=amit.kucheria@verdurent.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.w.gonzalez@free.fr \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).