From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>, Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH v3 7/7] backlight: gpio: use a helper variable for &pdev->dev
Date: Wed, 24 Jul 2019 10:25:08 +0200 [thread overview]
Message-ID: <20190724082508.27617-8-brgl@bgdev.pl> (raw)
In-Reply-To: <20190724082508.27617-1-brgl@bgdev.pl>
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Instead of dereferencing pdev each time, use a helper variable for
the associated device pointer.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
drivers/video/backlight/gpio_backlight.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
index cd6a75bca9cc..7dc4f90d926b 100644
--- a/drivers/video/backlight/gpio_backlight.c
+++ b/drivers/video/backlight/gpio_backlight.c
@@ -54,29 +54,29 @@ static const struct backlight_ops gpio_backlight_ops = {
static int gpio_backlight_probe(struct platform_device *pdev)
{
- struct gpio_backlight_platform_data *pdata =
- dev_get_platdata(&pdev->dev);
+ struct device *dev = &pdev->dev;
+ struct gpio_backlight_platform_data *pdata = dev_get_platdata(dev);
struct backlight_properties props;
struct backlight_device *bl;
struct gpio_backlight *gbl;
enum gpiod_flags flags;
int ret, def_value;
- gbl = devm_kzalloc(&pdev->dev, sizeof(*gbl), GFP_KERNEL);
+ gbl = devm_kzalloc(dev, sizeof(*gbl), GFP_KERNEL);
if (gbl == NULL)
return -ENOMEM;
if (pdata)
gbl->fbdev = pdata->fbdev;
- def_value = device_property_read_bool(&pdev->dev, "default-on");
+ def_value = device_property_read_bool(dev, "default-on");
flags = def_value ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW;
- gbl->gpiod = devm_gpiod_get(&pdev->dev, NULL, flags);
+ gbl->gpiod = devm_gpiod_get(dev, NULL, flags);
if (IS_ERR(gbl->gpiod)) {
ret = PTR_ERR(gbl->gpiod);
if (ret != -EPROBE_DEFER) {
- dev_err(&pdev->dev,
+ dev_err(dev,
"Error: The gpios parameter is missing or invalid.\n");
}
return ret;
@@ -85,11 +85,10 @@ static int gpio_backlight_probe(struct platform_device *pdev)
memset(&props, 0, sizeof(props));
props.type = BACKLIGHT_RAW;
props.max_brightness = 1;
- bl = devm_backlight_device_register(&pdev->dev, dev_name(&pdev->dev),
- &pdev->dev, gbl, &gpio_backlight_ops,
- &props);
+ bl = devm_backlight_device_register(dev, dev_name(dev), dev, gbl,
+ &gpio_backlight_ops, &props);
if (IS_ERR(bl)) {
- dev_err(&pdev->dev, "failed to register backlight\n");
+ dev_err(dev, "failed to register backlight\n");
return PTR_ERR(bl);
}
--
2.21.0
next prev parent reply other threads:[~2019-07-24 8:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 8:25 [PATCH v3 0/7] backlight: gpio: simplify the driver Bartosz Golaszewski
2019-07-24 8:25 ` [PATCH v3 1/7] sh: ecovec24: add additional properties to the backlight device Bartosz Golaszewski
2019-07-24 8:25 ` [PATCH v3 2/7] backlight: gpio: simplify the platform data handling Bartosz Golaszewski
2019-07-24 11:12 ` Daniel Thompson
2019-07-24 11:44 ` Andy Shevchenko
2019-07-24 8:25 ` [PATCH v3 3/7] sh: ecovec24: don't set unused fields in platform data Bartosz Golaszewski
2019-07-24 8:25 ` [PATCH v3 4/7] backlight: gpio: remove unused fields from " Bartosz Golaszewski
2019-07-24 11:13 ` Daniel Thompson
2019-07-24 8:25 ` [PATCH v3 5/7] backlight: gpio: remove dev from struct gpio_backlight Bartosz Golaszewski
2019-07-24 11:13 ` Daniel Thompson
2019-07-24 8:25 ` [PATCH v3 6/7] backlight: gpio: remove def_value " Bartosz Golaszewski
2019-07-24 11:13 ` Daniel Thompson
2019-07-24 8:25 ` Bartosz Golaszewski [this message]
2019-07-24 11:13 ` [PATCH v3 7/7] backlight: gpio: use a helper variable for &pdev->dev Daniel Thompson
2019-07-24 11:41 ` Andy Shevchenko
2019-07-24 8:27 ` [PATCH v3 0/7] backlight: gpio: simplify the driver Bartosz Golaszewski
2019-08-05 21:12 ` Linus Walleij
2019-08-08 8:17 ` Bartosz Golaszewski
2019-08-16 15:48 ` Bartosz Golaszewski
2019-08-28 7:32 ` Bartosz Golaszewski
2019-08-28 8:36 ` Geert Uytterhoeven
2019-08-28 16:31 ` Linus Walleij
2019-08-28 16:40 ` Jacopo Mondi
2019-09-02 9:31 ` Lee Jones
2019-09-02 12:35 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724082508.27617-8-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=andriy.shevchenko@linux.intel.com \
--cc=b.zolnierkie@samsung.com \
--cc=bgolaszewski@baylibre.com \
--cc=dalias@libc.org \
--cc=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).