From: Richard Weinberger <richard@nod.at>
To: linux-crypto@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Cc: horia.geanta@nxp.com, aymen.sghaier@nxp.com, david <david@sigma-star.at>
Subject: Backlog support for CAAM?
Date: Wed, 24 Jul 2019 23:22:08 +0200 (CEST) [thread overview]
Message-ID: <839258138.49105.1564003328543.JavaMail.zimbra@nod.at> (raw)
Hi!
Recently I had the pleasure to debug a lockup on a imx6 based platform.
It turned out that the lockup was caused by the CAAM driver because it
just returns -EBUSY upon a full job ring.
Then I found commits:
0618764cb25f ("dm crypt: fix deadlock when async crypto algorithm returns -EBUSY")
c0403ec0bb5a ("Revert "dm crypt: fix deadlock when async crypto algorithm returns -EBUSY"")
Is there a reason why the driver has still no proper backlog support?
If it is just a matter of -ENOPATCH, I have some cycles left an can help.
But before working on this topic I'd like to figure what the current state
or plans are. :-)
So far I work around the issue with disgusting hacks like this one:
--- a/drivers/crypto/caam/jr.c
+++ b/drivers/crypto/caam/jr.c
@@ -339,6 +339,7 @@ int caam_jr_enqueue(struct device *dev, u32 *desc,
return -EIO;
}
+again:
spin_lock_bh(&jrp->inplock);
head = jrp->head;
@@ -347,8 +348,8 @@ int caam_jr_enqueue(struct device *dev, u32 *desc,
if (!rd_reg32(&jrp->rregs->inpring_avail) ||
CIRC_SPACE(head, tail, JOBR_DEPTH) <= 0) {
spin_unlock_bh(&jrp->inplock);
- dma_unmap_single(dev, desc_dma, desc_size, DMA_TO_DEVICE);
- return -EBUSY;
+ msleep(100);
+ goto again;
}
head_entry = &jrp->entinfo[head];
Thanks,
//richard
next reply other threads:[~2019-07-24 21:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 21:22 Richard Weinberger [this message]
2019-07-25 5:57 ` Backlog support for CAAM? Horia Geanta
2019-07-25 8:12 ` Richard Weinberger
2019-07-28 20:50 ` Richard Weinberger
2019-07-30 10:28 ` Horia Geanta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=839258138.49105.1564003328543.JavaMail.zimbra@nod.at \
--to=richard@nod.at \
--cc=aymen.sghaier@nxp.com \
--cc=david@sigma-star.at \
--cc=horia.geanta@nxp.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).