From: Iuliana Prodan <iuliana.prodan@nxp.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
Horia Geanta <horia.geanta@nxp.com>,
Aymen Sghaier <aymen.sghaier@nxp.com>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-imx <linux-imx@nxp.com>
Subject: [PATCH v3 14/14] crypto: caam - change return value in case CAAM has no MDHA
Date: Thu, 25 Jul 2019 16:58:26 +0300 [thread overview]
Message-ID: <1564063106-9552-15-git-send-email-iuliana.prodan@nxp.com> (raw)
In-Reply-To: <1564063106-9552-1-git-send-email-iuliana.prodan@nxp.com>
To be consistent with other CAAM modules, caamhash should return 0
instead of -ENODEV in case CAAM has no MDHA.
Based on commit 1b46c90c8e00 ("crypto: caam - convert top level drivers to libraries")
the value returned by entry point is never checked and
the exit point is always executed.
Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com>
Reviewed-by: Horia Geanta <horia.geanta@nxp.com>
---
drivers/crypto/caam/caamhash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/caam/caamhash.c b/drivers/crypto/caam/caamhash.c
index 7147190..3a1dfd2 100644
--- a/drivers/crypto/caam/caamhash.c
+++ b/drivers/crypto/caam/caamhash.c
@@ -2007,7 +2007,7 @@ int caam_algapi_hash_init(struct device *ctrldev)
* is not present.
*/
if (!md_inst)
- return -ENODEV;
+ return 0;
/* Limit digest size based on LP256 */
if (md_vid == CHA_VER_VID_MD_LP256)
--
2.1.0
prev parent reply other threads:[~2019-07-25 13:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 13:58 [PATCH v3 00/14] crypto: caam - fixes for kernel v5.3 Iuliana Prodan
2019-07-25 13:58 ` [PATCH v3 01/14] crypto: caam/qi - fix error handling in ERN handler Iuliana Prodan
2019-07-25 13:58 ` [PATCH v3 02/14] crypto: caam - fix return code in completion callbacks Iuliana Prodan
2019-07-25 13:58 ` [PATCH v3 03/14] crypto: caam - update IV only when crypto operation succeeds Iuliana Prodan
2019-07-26 14:57 ` Horia Geanta
2019-07-25 13:58 ` [PATCH v3 04/14] crypto: caam - check key length Iuliana Prodan
2019-07-26 15:19 ` Horia Geanta
2019-07-25 13:58 ` [PATCH v3 05/14] crypto: caam - check authsize Iuliana Prodan
2019-07-26 15:25 ` Horia Geanta
2019-07-25 13:58 ` [PATCH v3 06/14] crypto: caam - check assoclen Iuliana Prodan
2019-07-26 15:28 ` Horia Geanta
2019-07-25 13:58 ` [PATCH v3 07/14] crypto: caam - check zero-length input Iuliana Prodan
2019-07-25 13:58 ` [PATCH v3 08/14] crypto: caam - update rfc4106 sh desc to support zero length input Iuliana Prodan
2019-07-26 15:44 ` Horia Geanta
2019-07-25 13:58 ` [PATCH v3 09/14] crypto: caam - keep both virtual and dma key addresses Iuliana Prodan
2019-07-25 13:58 ` [PATCH v3 10/14] crypto: caam - fix MDHA key derivation for certain user key lengths Iuliana Prodan
2019-07-26 15:04 ` Horia Geanta
2019-07-25 13:58 ` [PATCH v3 11/14] crypto: caam - free resources in case caam_rng registration failed Iuliana Prodan
2019-07-26 15:53 ` Horia Geanta
2019-07-25 13:58 ` [PATCH v3 12/14] crypto: caam - execute module exit point only if necessary Iuliana Prodan
2019-07-25 13:58 ` [PATCH v3 13/14] crypto: caam - unregister algorithm only if the registration succeeded Iuliana Prodan
2019-07-25 13:58 ` Iuliana Prodan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1564063106-9552-15-git-send-email-iuliana.prodan@nxp.com \
--to=iuliana.prodan@nxp.com \
--cc=aymen.sghaier@nxp.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@nxp.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).