From: Chuhong Yuan <hslester96@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Chuhong Yuan <hslester96@gmail.com>
Subject: [PATCH v2 07/10] reboot: Replace strncmp with str_has_prefix
Date: Fri, 2 Aug 2019 09:47:25 +0800 [thread overview]
Message-ID: <20190802014725.9006-1-hslester96@gmail.com> (raw)
strncmp(str, const, len) is error-prone because len
is easy to have typo.
The example is the hard-coded len has counting error
or sizeof(const) forgets - 1.
So we prefer using newly introduced str_has_prefix
to substitute such strncmp.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
Changes in v2:
- Revise the description.
- Utilize str_has_prefix's return value to
eliminate some hard codes.
kernel/reboot.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/kernel/reboot.c b/kernel/reboot.c
index c4d472b7f1b4..addb52391177 100644
--- a/kernel/reboot.c
+++ b/kernel/reboot.c
@@ -520,6 +520,8 @@ EXPORT_SYMBOL_GPL(orderly_reboot);
static int __init reboot_setup(char *str)
{
+ size_t len;
+
for (;;) {
enum reboot_mode *mode;
@@ -530,9 +532,9 @@ static int __init reboot_setup(char *str)
*/
reboot_default = 0;
- if (!strncmp(str, "panic_", 6)) {
+ if ((len = str_has_prefix(str, "panic_"))) {
mode = &panic_reboot_mode;
- str += 6;
+ str += len;
} else {
mode = &reboot_mode;
}
--
2.20.1
reply other threads:[~2019-08-02 1:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190802014725.9006-1-hslester96@gmail.com \
--to=hslester96@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).