From: Jia He <justin.he@arm.com>
To: Petr Mladek <pmladek@suse.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Cc: "Steven Rostedt (VMware)" <rostedt@goodmis.org>,
Kees Cook <keescook@chromium.org>, Shuah Khan <shuah@kernel.org>,
"Tobin C. Harding" <tobin@kernel.org>, Jia He <justin.he@arm.com>
Subject: [PATCH 2/2] lib/test_printf: add test of null/invalid pointer dereference for dentry
Date: Fri, 9 Aug 2019 09:24:57 +0800 [thread overview]
Message-ID: <20190809012457.56685-2-justin.he@arm.com> (raw)
In-Reply-To: <20190809012457.56685-1-justin.he@arm.com>
This add some additional test cases of null/invalid pointer dereference
for dentry and file (%pd and %pD)
Signed-off-by: Jia He <justin.he@arm.com>
---
lib/test_printf.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/lib/test_printf.c b/lib/test_printf.c
index 944eb50f3862..befedffeb476 100644
--- a/lib/test_printf.c
+++ b/lib/test_printf.c
@@ -455,6 +455,13 @@ dentry(void)
test("foo", "%pd", &test_dentry[0]);
test("foo", "%pd2", &test_dentry[0]);
+ /* test the null/invalid pointer case for dentry */
+ test("(null)", "%pd", NULL);
+ test("(efault)", "%pd", PTR_INVALID);
+ /* test the null/invalid pointer case for file */
+ test("(null)", "%pD", NULL);
+ test("(efault)", "%pD", PTR_INVALID);
+
test("romeo", "%pd", &test_dentry[3]);
test("alfa/romeo", "%pd2", &test_dentry[3]);
test("bravo/alfa/romeo", "%pd3", &test_dentry[3]);
--
2.17.1
next prev parent reply other threads:[~2019-08-09 1:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 1:24 [PATCH 1/2] vsprintf: Prevent crash when dereferencing invalid pointers for %pD Jia He
2019-08-09 1:24 ` Jia He [this message]
2019-08-09 10:51 ` [PATCH 2/2] lib/test_printf: add test of null/invalid pointer dereference for dentry Andy Shevchenko
2019-08-16 8:26 ` Petr Mladek
2019-08-16 8:31 ` Justin He (Arm Technology China)
2019-08-09 10:51 ` [PATCH 1/2] vsprintf: Prevent crash when dereferencing invalid pointers for %pD Andy Shevchenko
2019-08-09 10:56 ` Justin He (Arm Technology China)
2019-08-16 8:20 ` Petr Mladek
2019-08-15 7:52 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809012457.56685-2-justin.he@arm.com \
--to=justin.he@arm.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=geert+renesas@glider.be \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=tobin@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).