From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: David Rheinsberg <david.rheinsberg@gmail.com>,
Jiri Kosina <jikos@kernel.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: [PATCH] HID: uhid: actually use the err number from userspace
Date: Mon, 12 Aug 2019 18:21:05 +0200 [thread overview]
Message-ID: <20190812162105.13428-1-benjamin.tissoires@redhat.com> (raw)
This can help debugging the situation
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
Hi,
not entirely sure if we can use this in a such simple way.
However, this is useful to mimic device behaviour from userspace.
Cheers,
Benjamin
drivers/hid/uhid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c
index fa0cc0899827..2fa32e7fc733 100644
--- a/drivers/hid/uhid.c
+++ b/drivers/hid/uhid.c
@@ -284,7 +284,7 @@ static int uhid_hid_set_report(struct hid_device *hid, unsigned char rnum,
goto unlock;
if (uhid->report_buf.u.set_report_reply.err)
- ret = -EIO;
+ ret = -uhid->report_buf.u.set_report_reply.err;
else
ret = count;
--
2.19.2
next reply other threads:[~2019-08-12 16:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 16:21 Benjamin Tissoires [this message]
2019-08-13 10:49 ` [PATCH] HID: uhid: actually use the err number from userspace David Rheinsberg
2019-08-13 13:58 ` Benjamin Tissoires
2019-08-14 8:30 ` David Rheinsberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190812162105.13428-1-benjamin.tissoires@redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=david.rheinsberg@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).