From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org,
Stefan Mavrodiev <stefan@olimex.com>,
Chen-Yu Tsai <wens@csie.org>,
Vasily Khoruzhick <anarsoul@gmail.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: [PATCH 3/7] nvmem: sunxi_sid: fix A64 SID controller support
Date: Sun, 18 Aug 2019 10:33:41 +0100 [thread overview]
Message-ID: <20190818093345.29647-4-srinivas.kandagatla@linaro.org> (raw)
In-Reply-To: <20190818093345.29647-1-srinivas.kandagatla@linaro.org>
From: Stefan Mavrodiev <stefan@olimex.com>
Like in H3, A64 SID controller doesn't return correct data
when using direct access. It appears that on A64, SID needs
8 bytes of word_size.
Workaround is to enable read by registers.
Signed-off-by: Stefan Mavrodiev <stefan@olimex.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Tested-by: Vasily Khoruzhick <anarsoul@gmail.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
drivers/nvmem/sunxi_sid.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nvmem/sunxi_sid.c b/drivers/nvmem/sunxi_sid.c
index a079a80ddf2c..e26ef1bbf198 100644
--- a/drivers/nvmem/sunxi_sid.c
+++ b/drivers/nvmem/sunxi_sid.c
@@ -186,6 +186,7 @@ static const struct sunxi_sid_cfg sun8i_h3_cfg = {
static const struct sunxi_sid_cfg sun50i_a64_cfg = {
.value_offset = 0x200,
.size = 0x100,
+ .need_register_readout = true,
};
static const struct sunxi_sid_cfg sun50i_h6_cfg = {
--
2.21.0
next prev parent reply other threads:[~2019-08-18 9:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-18 9:33 [PATCH 0/7] nvmem: patches(set 1) for 5.4 Srinivas Kandagatla
2019-08-18 9:33 ` [PATCH 1/7] dt-bindings: imx-ocotp: Add i.MX8MN compatible Srinivas Kandagatla
2019-08-18 9:33 ` [PATCH 2/7] nvmem: imx-ocotp: Add i.MX8MN support Srinivas Kandagatla
2019-08-18 9:33 ` Srinivas Kandagatla [this message]
2019-08-18 9:33 ` [PATCH 4/7] nvmem: meson-mx-efuse: allow reading data smaller than word_size Srinivas Kandagatla
2019-08-18 9:33 ` [PATCH 5/7] nvmem: mxs-ocotp: update MODULE_AUTHOR() email address Srinivas Kandagatla
2019-08-18 9:33 ` [PATCH 6/7] dt-bindings: fsl: scu: add new compatible string for ocotp Srinivas Kandagatla
2019-08-18 9:33 ` [PATCH 7/7] nvmem: imx: add i.MX8QM platform support Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190818093345.29647-4-srinivas.kandagatla@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=anarsoul@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefan@olimex.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).