soc: ixp4xx: Protect IXP4xx SoC drivers by ARCH_IXP4XX || COMPILE_TEST
diff mbox series

Message ID 20190819080028.13091-1-geert@linux-m68k.org
State Accepted
Commit 7a6c9dbb36a415c5901313fc89871fd19f533656
Headers show
Series
  • soc: ixp4xx: Protect IXP4xx SoC drivers by ARCH_IXP4XX || COMPILE_TEST
Related show

Commit Message

Geert Uytterhoeven Aug. 19, 2019, 8 a.m. UTC
The move of the IXP4xx SoC drivers exposed their config options on all
platforms.

Fix this by wrapping them inside an ARCH_IXP4XX or COMPILE_TEST block.

Fixes: fcf2d8978cd538a5 ("ARM: ixp4xx: Move NPE and QMGR to drivers/soc")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
v2:
  - Rebased on top of commit ec8f24b7faaf3d47 ("treewide: Add SPDX
    license identifier - Makefile/Kconfig").
---
 drivers/soc/ixp4xx/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Linus Walleij Aug. 23, 2019, 8:26 a.m. UTC | #1
On Mon, Aug 19, 2019 at 10:46 AM Geert Uytterhoeven
<geert@linux-m68k.org> wrote:

> The move of the IXP4xx SoC drivers exposed their config options on all
> platforms.
>
> Fix this by wrapping them inside an ARCH_IXP4XX or COMPILE_TEST block.
>
> Fixes: fcf2d8978cd538a5 ("ARM: ixp4xx: Move NPE and QMGR to drivers/soc")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> v2:
>   - Rebased on top of commit ec8f24b7faaf3d47 ("treewide: Add SPDX
>     license identifier - Makefile/Kconfig").

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Do you want me to also take care of sending this into the ARM SoC tree?

Yours,
Linus Walleij
Geert Uytterhoeven Aug. 23, 2019, 8:28 a.m. UTC | #2
Hi Linus,

On Fri, Aug 23, 2019 at 10:26 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> On Mon, Aug 19, 2019 at 10:46 AM Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > The move of the IXP4xx SoC drivers exposed their config options on all
> > platforms.
> >
> > Fix this by wrapping them inside an ARCH_IXP4XX or COMPILE_TEST block.
> >
> > Fixes: fcf2d8978cd538a5 ("ARM: ixp4xx: Move NPE and QMGR to drivers/soc")
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > ---
> > v2:
> >   - Rebased on top of commit ec8f24b7faaf3d47 ("treewide: Add SPDX
> >     license identifier - Makefile/Kconfig").
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Do you want me to also take care of sending this into the ARM SoC tree?

Given you're listed as (one of) the maintainer(s), I think that would make
perfect sense.

Thanks!

Gr{oetje,eeting}s,

                        Geert

Patch
diff mbox series

diff --git a/drivers/soc/ixp4xx/Kconfig b/drivers/soc/ixp4xx/Kconfig
index de2e62c3310a37d0..e3eb19b85fa4b358 100644
--- a/drivers/soc/ixp4xx/Kconfig
+++ b/drivers/soc/ixp4xx/Kconfig
@@ -1,4 +1,6 @@ 
 # SPDX-License-Identifier: GPL-2.0-only
+if ARCH_IXP4XX || COMPILE_TEST
+
 menu "IXP4xx SoC drivers"
 
 config IXP4XX_QMGR
@@ -15,3 +17,5 @@  config IXP4XX_NPE
 	  and is automatically selected by Ethernet and HSS drivers.
 
 endmenu
+
+endif