From: YueHaibing <yuehaibing@huawei.com>
To: <davem@davemloft.net>, <idosch@mellanox.com>, <jiri@mellanox.com>,
<mcroce@redhat.com>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
YueHaibing <yuehaibing@huawei.com>
Subject: [PATCH net-next] netdevsim: Fix build error without CONFIG_INET
Date: Mon, 19 Aug 2019 20:08:25 +0800 [thread overview]
Message-ID: <20190819120825.74460-1-yuehaibing@huawei.com> (raw)
If CONFIG_INET is not set, building fails:
drivers/net/netdevsim/dev.o: In function `nsim_dev_trap_report_work':
dev.c:(.text+0x67b): undefined reference to `ip_send_check'
Add CONFIG_INET Kconfig dependency to fix this.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: da58f90f11f5 ("netdevsim: Add devlink-trap support")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 48e209e..7bb786e 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -505,7 +505,7 @@ source "drivers/net/hyperv/Kconfig"
config NETDEVSIM
tristate "Simulated networking device"
- depends on DEBUG_FS
+ depends on INET && DEBUG_FS
select NET_DEVLINK
help
This driver is a developer testing tool and software model that can
--
2.7.4
next reply other threads:[~2019-08-19 12:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 12:08 YueHaibing [this message]
2019-08-19 15:58 ` [PATCH net-next] netdevsim: Fix build error without CONFIG_INET Ido Schimmel
2019-08-19 21:59 ` Jakub Kicinski
2019-08-20 14:08 ` Ido Schimmel
2019-08-20 14:14 ` [PATCH v2 " YueHaibing
2019-08-20 17:48 ` Jakub Kicinski
2019-08-20 18:10 ` Ido Schimmel
2019-08-20 20:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190819120825.74460-1-yuehaibing@huawei.com \
--to=yuehaibing@huawei.com \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).