From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Linux Kernel Development <linux-kernel@vger.kernel.org>
Cc: Rusty Trivial Russell <trivial@rustcorp.com.au>
Subject: [PATCH] SCSI on non-ISA systems
Date: Fri, 8 Nov 2002 14:46:40 +0100 (MET) [thread overview]
Message-ID: <Pine.GSO.4.21.0211081443590.23267-100000@vervain.sonytel.be> (raw)
Since 2.5.31, the compilation of kernel/dma.c is conditional on
CONFIG_GENERIC_ISA_DMA. However, drivers/scsi/hosts.c unconditionally calls
free_dma(), which breaks machines with SCSI that don't have ISA.
Please apply!
--- linux-2.5.46/drivers/scsi/hosts.c Thu Oct 31 10:15:33 2002
+++ linux-m68k-2.5.46/drivers/scsi/hosts.c Fri Nov 8 14:27:59 2002
@@ -27,6 +27,7 @@
* hosts currently present in the system.
*/
+#include <linux/config.h>
#include <linux/module.h>
#include <linux/blk.h>
#include <linux/kernel.h>
@@ -98,8 +99,10 @@
{
if (shost->irq)
free_irq(shost->irq, NULL);
+#ifdef CONFIG_GENERIC_ISA_DMA
if (shost->dma_channel != 0xff)
free_dma(shost->dma_channel);
+#endif
if (shost->io_port && shost->n_io_port)
release_region(shost->io_port, shost->n_io_port);
}
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next reply other threads:[~2002-11-08 13:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-08 13:46 Geert Uytterhoeven [this message]
2002-11-08 13:57 ` [PATCH] SCSI on non-ISA systems Russell King
2002-11-08 14:22 ` Geert Uytterhoeven
2002-11-08 14:42 ` Russell King
2002-11-08 16:20 ` Alan Cox
2002-11-09 0:50 ` Mike Anderson
2002-11-09 0:53 ` Christoph Hellwig
2002-11-09 13:13 ` Alan Cox
2002-11-09 14:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.21.0211081443590.23267-100000@vervain.sonytel.be \
--to=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).