From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: linux-rtc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: [PATCH v3 9/9] rtc: pcf2123: add proper compatible string
Date: Mon, 19 Aug 2019 20:26:56 +0200 [thread overview]
Message-ID: <20190819182656.29744-9-alexandre.belloni@bootlin.com> (raw)
In-Reply-To: <20190819182656.29744-1-alexandre.belloni@bootlin.com>
nxp,rtc-pcf2123 is not a proper compatible strong for this RTC. The part
name is only pcf2123 and is less confusing.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
Documentation/devicetree/bindings/rtc/nxp,rtc-2123.txt | 4 ++--
drivers/rtc/rtc-pcf2123.c | 4 +++-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/rtc/nxp,rtc-2123.txt b/Documentation/devicetree/bindings/rtc/nxp,rtc-2123.txt
index 1994f601800a..7371f525a687 100644
--- a/Documentation/devicetree/bindings/rtc/nxp,rtc-2123.txt
+++ b/Documentation/devicetree/bindings/rtc/nxp,rtc-2123.txt
@@ -1,7 +1,7 @@
NXP PCF2123 SPI Real Time Clock
Required properties:
-- compatible: should be: "nxp,rtc-pcf2123"
+- compatible: should be: "nxp,pcf2123"
or "microcrystal,rv2123"
- reg: should be the SPI slave chipselect address
@@ -11,7 +11,7 @@ Optional properties:
Example:
pcf2123: rtc@3 {
- compatible = "nxp,rtc-pcf2123"
+ compatible = "nxp,pcf2123"
reg = <3>
spi-cs-high;
};
diff --git a/drivers/rtc/rtc-pcf2123.c b/drivers/rtc/rtc-pcf2123.c
index bda4b1687318..c3691fa4210e 100644
--- a/drivers/rtc/rtc-pcf2123.c
+++ b/drivers/rtc/rtc-pcf2123.c
@@ -443,8 +443,10 @@ static int pcf2123_probe(struct spi_device *spi)
#ifdef CONFIG_OF
static const struct of_device_id pcf2123_dt_ids[] = {
- { .compatible = "nxp,rtc-pcf2123", },
+ { .compatible = "nxp,pcf2123", },
{ .compatible = "microcrystal,rv2123", },
+ /* Deprecated, do not use */
+ { .compatible = "nxp,rtc-pcf2123", },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, pcf2123_dt_ids);
--
2.21.0
prev parent reply other threads:[~2019-08-19 18:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 18:26 [PATCH v3 1/9] rtc: pcf2123: don't use weekday alarm Alexandre Belloni
2019-08-19 18:26 ` [PATCH v3 2/9] rtc; pcf2123: fix possible alarm race condition Alexandre Belloni
2019-08-19 18:26 ` [PATCH v3 3/9] rtc: pcf2123: implement .alarm_irq_enable Alexandre Belloni
2019-08-19 18:26 ` [PATCH v3 4/9] rtc: pcf2123: stop using dev.platform_data Alexandre Belloni
2019-08-19 18:26 ` [PATCH v3 5/9] rtc: pcf2123: rename struct and variables Alexandre Belloni
2019-08-19 18:26 ` [PATCH v3 6/9] rtc: pcf2123: remove useless error path goto Alexandre Belloni
2019-08-19 18:26 ` [PATCH v3 7/9] rtc: pcf2123: convert to devm_rtc_allocate_device Alexandre Belloni
2019-08-19 18:26 ` [PATCH v3 8/9] rtc: pcf2123: let the core handle range offsetting Alexandre Belloni
2019-08-19 18:26 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190819182656.29744-9-alexandre.belloni@bootlin.com \
--to=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).