From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: linux-rtc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: [PATCH v3 3/9] rtc: pcf2123: implement .alarm_irq_enable
Date: Mon, 19 Aug 2019 20:26:50 +0200 [thread overview]
Message-ID: <20190819182656.29744-3-alexandre.belloni@bootlin.com> (raw)
In-Reply-To: <20190819182656.29744-1-alexandre.belloni@bootlin.com>
Implement .alarm_irq_enable so it is possible to use RTC_ALM_SET,
RTC_AIE_ON and RTC_AIE_OFF.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
drivers/rtc/rtc-pcf2123.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/rtc/rtc-pcf2123.c b/drivers/rtc/rtc-pcf2123.c
index 829d7a2dd950..809c35c8ba1a 100644
--- a/drivers/rtc/rtc-pcf2123.c
+++ b/drivers/rtc/rtc-pcf2123.c
@@ -238,6 +238,14 @@ static int pcf2123_rtc_set_time(struct device *dev, struct rtc_time *tm)
return 0;
}
+static int pcf2123_rtc_alarm_irq_enable(struct device *dev, unsigned int en)
+{
+ struct pcf2123_plat_data *pdata = dev_get_platdata(dev);
+
+ return regmap_update_bits(pdata->map, PCF2123_REG_CTRL2, CTRL2_AIE,
+ en ? CTRL2_AIE : 0);
+}
+
static int pcf2123_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alm)
{
struct pcf2123_plat_data *pdata = dev_get_platdata(dev);
@@ -295,15 +303,7 @@ static int pcf2123_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alm)
if (ret)
return ret;
- /* Enable alarm interrupt */
- if (alm->enabled) {
- ret = regmap_update_bits(pdata->map, PCF2123_REG_CTRL2,
- CTRL2_AIE, CTRL2_AIE);
- if (ret)
- return ret;
- }
-
- return 0;
+ return pcf2123_rtc_alarm_irq_enable(dev, alm->enabled);
}
static irqreturn_t pcf2123_rtc_irq(int irq, void *dev)
@@ -372,6 +372,7 @@ static const struct rtc_class_ops pcf2123_rtc_ops = {
.set_offset = pcf2123_set_offset,
.read_alarm = pcf2123_rtc_read_alarm,
.set_alarm = pcf2123_rtc_set_alarm,
+ .alarm_irq_enable = pcf2123_rtc_alarm_irq_enable,
};
static int pcf2123_probe(struct spi_device *spi)
--
2.21.0
next prev parent reply other threads:[~2019-08-19 18:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 18:26 [PATCH v3 1/9] rtc: pcf2123: don't use weekday alarm Alexandre Belloni
2019-08-19 18:26 ` [PATCH v3 2/9] rtc; pcf2123: fix possible alarm race condition Alexandre Belloni
2019-08-19 18:26 ` Alexandre Belloni [this message]
2019-08-19 18:26 ` [PATCH v3 4/9] rtc: pcf2123: stop using dev.platform_data Alexandre Belloni
2019-08-19 18:26 ` [PATCH v3 5/9] rtc: pcf2123: rename struct and variables Alexandre Belloni
2019-08-19 18:26 ` [PATCH v3 6/9] rtc: pcf2123: remove useless error path goto Alexandre Belloni
2019-08-19 18:26 ` [PATCH v3 7/9] rtc: pcf2123: convert to devm_rtc_allocate_device Alexandre Belloni
2019-08-19 18:26 ` [PATCH v3 8/9] rtc: pcf2123: let the core handle range offsetting Alexandre Belloni
2019-08-19 18:26 ` [PATCH v3 9/9] rtc: pcf2123: add proper compatible string Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190819182656.29744-3-alexandre.belloni@bootlin.com \
--to=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).