From: Kyle Meyer <meyerk@hpe.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Kyle Meyer <meyerk@hpe.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org,
Russ Anderson <russ.anderson@hpe.com>,
Kyle Meyer <kyle.meyer@hpe.com>
Subject: [PATCH v3 4/6] perf/util/session: Replace MAX_NR_CPUS with nr_cpus_online
Date: Mon, 19 Aug 2019 15:23:33 -0500 [thread overview]
Message-ID: <20190819202333.88032-1-meyerk@stormcage.eag.rdlabs.hpecorp.net> (raw)
nr_cpus_online, the number of CPUs online during a record session, can be
used as a dynamic alternative for MAX_NR_CPUS in perf_session__cpu_bitmap.
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: linux-kernel@vger.kernel.org
Cc: Russ Anderson <russ.anderson@hpe.com>
Signed-off-by: Kyle Meyer <kyle.meyer@hpe.com>
---
tools/perf/util/session.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Index: tip/tools/perf/util/session.c
===================================================================
--- tip.orig/tools/perf/util/session.c
+++ tip/tools/perf/util/session.c
@@ -2284,6 +2284,7 @@ int perf_session__cpu_bitmap(struct perf
{
int i, err = -1;
struct perf_cpu_map *map;
+ int nr_cpus_online = session->header.env.nr_cpus_online;
for (i = 0; i < PERF_TYPE_MAX; ++i) {
struct evsel *evsel;
@@ -2308,9 +2309,8 @@ int perf_session__cpu_bitmap(struct perf
for (i = 0; i < map->nr; i++) {
int cpu = map->map[i];
- if (cpu >= MAX_NR_CPUS) {
- pr_err("Requested CPU %d too large. "
- "Consider raising MAX_NR_CPUS\n", cpu);
+ if (cpu >= nr_cpus_online) {
+ pr_err("Requested CPU %d too large\n", cpu);
goto out_delete_map;
}
next reply other threads:[~2019-08-19 20:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 20:23 Kyle Meyer [this message]
2019-08-20 9:18 ` [PATCH v3 4/6] perf/util/session: Replace MAX_NR_CPUS with nr_cpus_online Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190819202333.88032-1-meyerk@stormcage.eag.rdlabs.hpecorp.net \
--to=meyerk@hpe.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=kyle.meyer@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=russ.anderson@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).