From: Wenwen Wang <wenwen@cs.uga.edu>
To: Wenwen Wang <wenwen@cs.uga.edu>
Cc: Tyler Hicks <tyhicks@canonical.com>,
ecryptfs@vger.kernel.org (open list:ECRYPT FILE SYSTEM),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] ecryptfs: fix a memory leak bug
Date: Tue, 20 Aug 2019 00:33:54 -0500 [thread overview]
Message-ID: <1566279234-9634-1-git-send-email-wenwen@cs.uga.edu> (raw)
In ecryptfs_init_messaging(), if the allocation for 'ecryptfs_msg_ctx_arr'
fails, the previously allocated 'ecryptfs_daemon_hash' is not deallocated,
leading to a memory leak bug. To fix this issue, free
'ecryptfs_daemon_hash' before returning the error.
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
---
fs/ecryptfs/messaging.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/ecryptfs/messaging.c b/fs/ecryptfs/messaging.c
index d668e60..c05ca39 100644
--- a/fs/ecryptfs/messaging.c
+++ b/fs/ecryptfs/messaging.c
@@ -379,6 +379,7 @@ int __init ecryptfs_init_messaging(void)
* ecryptfs_message_buf_len),
GFP_KERNEL);
if (!ecryptfs_msg_ctx_arr) {
+ kfree(ecryptfs_daemon_hash);
rc = -ENOMEM;
goto out;
}
--
2.7.4
next reply other threads:[~2019-08-20 5:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 5:33 Wenwen Wang [this message]
2019-08-20 7:11 ` [PATCH] ecryptfs: fix a memory leak bug Tyler Hicks
-- strict thread matches above, loose matches on Subject: below --
2019-08-20 5:16 Wenwen Wang
2019-08-20 7:10 ` Tyler Hicks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1566279234-9634-1-git-send-email-wenwen@cs.uga.edu \
--to=wenwen@cs.uga.edu \
--cc=ecryptfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tyhicks@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).