From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: linux-kbuild@vger.kernel.org
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
linux-kernel@vger.kernel.org
Subject: [PATCH 6/6] kbuild: check clean srctree even earlier
Date: Thu, 22 Aug 2019 13:46:13 +0900 [thread overview]
Message-ID: <20190822044613.5349-6-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <20190822044613.5349-1-yamada.masahiro@socionext.com>
Move the outputmakefile target to the leftmost in the prerequisite list
so that this is checked first. There is no guarantee that Make runs the
prerequisites from left to right, but at least the released versions of
GNU Make work like that when the parallel build option is not given.
Of course, when the parallel option -j given, other targets will be run
simultaneously but it is nice to show the error as early as possible.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index 960df4d35b15..089983a8a028 100644
--- a/Makefile
+++ b/Makefile
@@ -581,10 +581,10 @@ ifdef config-build
include arch/$(SRCARCH)/Makefile
export KBUILD_DEFCONFIG KBUILD_KCONFIG CC_VERSION_TEXT
-config: scripts_basic outputmakefile FORCE
+config: outputmakefile scripts_basic FORCE
$(Q)$(MAKE) $(build)=scripts/kconfig $@
-%config: scripts_basic outputmakefile FORCE
+%config: outputmakefile scripts_basic FORCE
$(Q)$(MAKE) $(build)=scripts/kconfig $@
else #!config-build
@@ -1123,7 +1123,7 @@ scripts: scripts_basic scripts_dtc
PHONY += prepare archprepare
-archprepare: archheaders archscripts scripts include/config/kernel.release outputmakefile \
+archprepare: outputmakefile archheaders archscripts scripts include/config/kernel.release \
asm-generic $(version_h) $(autoksyms_h) include/generated/utsrelease.h
prepare0: archprepare
--
2.17.1
next prev parent reply other threads:[~2019-08-22 4:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 4:46 [PATCH 1/6] kbuild: remove 'Using ... as source for kernel' message Masahiro Yamada
2019-08-22 4:46 ` [PATCH 2/6] kbuild: Inform user to pass ARCH= for make mrproper only when necessary Masahiro Yamada
2019-08-22 4:46 ` [PATCH 3/6] kbuild: clarify where to run make mrproper when out-of-tree fails Masahiro Yamada
2019-08-22 4:46 ` [PATCH 4/6] kbuild: move the clean srctree check to the outputmakefile target Masahiro Yamada
2019-08-22 4:46 ` [PATCH 5/6] kbuild: remove prepare3 target Masahiro Yamada
2019-08-22 4:46 ` Masahiro Yamada [this message]
2019-08-29 16:25 ` [PATCH 6/6] kbuild: check clean srctree even earlier Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822044613.5349-6-yamada.masahiro@socionext.com \
--to=yamada.masahiro@socionext.com \
--cc=geert@linux-m68k.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).