[v2,2/2] ASoC: es8316: fix inverted L/R of headphone mixer volume
diff mbox series

Message ID 20190826153900.25969-2-katsuhiro@katsuster.net
State Accepted
Commit f6e77921969003eaf5dbae9c0b5feeb20c6caf50
Headers show
Series
  • [v2,1/2] ASoC: es8316: fix headphone mixer volume table
Related show

Commit Message

Katsuhiro Suzuki Aug. 26, 2019, 3:39 p.m. UTC
This patch fixes inverted Left-Right channel of headphone mixer
volume by wrong shift_left, shift_right values.

Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
---
 sound/soc/codecs/es8316.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Daniel Drake Aug. 27, 2019, 2:43 a.m. UTC | #1
On Mon, Aug 26, 2019 at 11:39 PM Katsuhiro Suzuki
<katsuhiro@katsuster.net> wrote:
>
> This patch fixes inverted Left-Right channel of headphone mixer
> volume by wrong shift_left, shift_right values.
>
> Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>

Agrees with the spec

Reviewed-by: Daniel Drake <drake@endlessm.com>

Patch
diff mbox series

diff --git a/sound/soc/codecs/es8316.c b/sound/soc/codecs/es8316.c
index f97d9c5210f0..e0da24611800 100644
--- a/sound/soc/codecs/es8316.c
+++ b/sound/soc/codecs/es8316.c
@@ -94,7 +94,7 @@  static const struct snd_kcontrol_new es8316_snd_controls[] = {
 	SOC_DOUBLE_TLV("Headphone Playback Volume", ES8316_CPHP_ICAL_VOL,
 		       4, 0, 3, 1, hpout_vol_tlv),
 	SOC_DOUBLE_TLV("Headphone Mixer Volume", ES8316_HPMIX_VOL,
-		       0, 4, 11, 0, hpmixer_gain_tlv),
+		       4, 0, 11, 0, hpmixer_gain_tlv),
 
 	SOC_ENUM("Playback Polarity", dacpol),
 	SOC_DOUBLE_R_TLV("DAC Playback Volume", ES8316_DAC_VOLL,