csky: use generic free_initrd_mem()
diff mbox series

Message ID 1566999319-8151-1-git-send-email-rppt@linux.ibm.com
State Accepted
Commit fdbdcddc2c93096e9b956de930d2d710a1342502
Headers show
Series
  • csky: use generic free_initrd_mem()
Related show

Commit Message

Mike Rapoport Aug. 28, 2019, 1:35 p.m. UTC
The csky implementation of free_initrd_mem() is an open-coded version of
free_reserved_area() without poisoning.

Remove it and make csky use the generic version of free_initrd_mem().

Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
---
 arch/csky/mm/init.c | 16 ----------------
 1 file changed, 16 deletions(-)

Comments

Guo Ren Aug. 28, 2019, 2:12 p.m. UTC | #1
Acked-by: Guo Ren <guoren@kernel.org>

On Wed, Aug 28, 2019 at 9:35 PM Mike Rapoport <rppt@linux.ibm.com> wrote:
>
> The csky implementation of free_initrd_mem() is an open-coded version of
> free_reserved_area() without poisoning.
>
> Remove it and make csky use the generic version of free_initrd_mem().
>
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
> ---
>  arch/csky/mm/init.c | 16 ----------------
>  1 file changed, 16 deletions(-)
>
> diff --git a/arch/csky/mm/init.c b/arch/csky/mm/init.c
> index eb0dc9e..d4c2292 100644
> --- a/arch/csky/mm/init.c
> +++ b/arch/csky/mm/init.c
> @@ -60,22 +60,6 @@ void __init mem_init(void)
>         mem_init_print_info(NULL);
>  }
>
> -#ifdef CONFIG_BLK_DEV_INITRD
> -void free_initrd_mem(unsigned long start, unsigned long end)
> -{
> -       if (start < end)
> -               pr_info("Freeing initrd memory: %ldk freed\n",
> -                       (end - start) >> 10);
> -
> -       for (; start < end; start += PAGE_SIZE) {
> -               ClearPageReserved(virt_to_page(start));
> -               init_page_count(virt_to_page(start));
> -               free_page(start);
> -               totalram_pages_inc();
> -       }
> -}
> -#endif
> -
>  extern char __init_begin[], __init_end[];
>
>  void free_initmem(void)
> --
> 2.7.4
>
Mike Rapoport Aug. 28, 2019, 2:39 p.m. UTC | #2
Hi,

On Wed, Aug 28, 2019 at 10:12:52PM +0800, Guo Ren wrote:
> Acked-by: Guo Ren <guoren@kernel.org>

Do you mind taking it via csky tree?
 
> On Wed, Aug 28, 2019 at 9:35 PM Mike Rapoport <rppt@linux.ibm.com> wrote:
> >
> > The csky implementation of free_initrd_mem() is an open-coded version of
> > free_reserved_area() without poisoning.
> >
> > Remove it and make csky use the generic version of free_initrd_mem().
> >
> > Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
> > ---
> >  arch/csky/mm/init.c | 16 ----------------
> >  1 file changed, 16 deletions(-)
> >
> > diff --git a/arch/csky/mm/init.c b/arch/csky/mm/init.c
> > index eb0dc9e..d4c2292 100644
> > --- a/arch/csky/mm/init.c
> > +++ b/arch/csky/mm/init.c
> > @@ -60,22 +60,6 @@ void __init mem_init(void)
> >         mem_init_print_info(NULL);
> >  }
> >
> > -#ifdef CONFIG_BLK_DEV_INITRD
> > -void free_initrd_mem(unsigned long start, unsigned long end)
> > -{
> > -       if (start < end)
> > -               pr_info("Freeing initrd memory: %ldk freed\n",
> > -                       (end - start) >> 10);
> > -
> > -       for (; start < end; start += PAGE_SIZE) {
> > -               ClearPageReserved(virt_to_page(start));
> > -               init_page_count(virt_to_page(start));
> > -               free_page(start);
> > -               totalram_pages_inc();
> > -       }
> > -}
> > -#endif
> > -
> >  extern char __init_begin[], __init_end[];
> >
> >  void free_initmem(void)
> > --
> > 2.7.4
> >
> 
> 
> -- 
> Best Regards
>  Guo Ren
> 
> ML: https://lore.kernel.org/linux-csky/
>
Guo Ren Aug. 28, 2019, 4:08 p.m. UTC | #3
Sure, no problem.

On Wed, Aug 28, 2019 at 10:39 PM Mike Rapoport <rppt@linux.ibm.com> wrote:
>
> Hi,
>
> On Wed, Aug 28, 2019 at 10:12:52PM +0800, Guo Ren wrote:
> > Acked-by: Guo Ren <guoren@kernel.org>
>
> Do you mind taking it via csky tree?
>
> > On Wed, Aug 28, 2019 at 9:35 PM Mike Rapoport <rppt@linux.ibm.com> wrote:
> > >
> > > The csky implementation of free_initrd_mem() is an open-coded version of
> > > free_reserved_area() without poisoning.
> > >
> > > Remove it and make csky use the generic version of free_initrd_mem().
> > >
> > > Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
> > > ---
> > >  arch/csky/mm/init.c | 16 ----------------
> > >  1 file changed, 16 deletions(-)
> > >
> > > diff --git a/arch/csky/mm/init.c b/arch/csky/mm/init.c
> > > index eb0dc9e..d4c2292 100644
> > > --- a/arch/csky/mm/init.c
> > > +++ b/arch/csky/mm/init.c
> > > @@ -60,22 +60,6 @@ void __init mem_init(void)
> > >         mem_init_print_info(NULL);
> > >  }
> > >
> > > -#ifdef CONFIG_BLK_DEV_INITRD
> > > -void free_initrd_mem(unsigned long start, unsigned long end)
> > > -{
> > > -       if (start < end)
> > > -               pr_info("Freeing initrd memory: %ldk freed\n",
> > > -                       (end - start) >> 10);
> > > -
> > > -       for (; start < end; start += PAGE_SIZE) {
> > > -               ClearPageReserved(virt_to_page(start));
> > > -               init_page_count(virt_to_page(start));
> > > -               free_page(start);
> > > -               totalram_pages_inc();
> > > -       }
> > > -}
> > > -#endif
> > > -
> > >  extern char __init_begin[], __init_end[];
> > >
> > >  void free_initmem(void)
> > > --
> > > 2.7.4
> > >
> >
> >
> > --
> > Best Regards
> >  Guo Ren
> >
> > ML: https://lore.kernel.org/linux-csky/
> >
>
> --
> Sincerely yours,
> Mike.
>

Patch
diff mbox series

diff --git a/arch/csky/mm/init.c b/arch/csky/mm/init.c
index eb0dc9e..d4c2292 100644
--- a/arch/csky/mm/init.c
+++ b/arch/csky/mm/init.c
@@ -60,22 +60,6 @@  void __init mem_init(void)
 	mem_init_print_info(NULL);
 }
 
-#ifdef CONFIG_BLK_DEV_INITRD
-void free_initrd_mem(unsigned long start, unsigned long end)
-{
-	if (start < end)
-		pr_info("Freeing initrd memory: %ldk freed\n",
-			(end - start) >> 10);
-
-	for (; start < end; start += PAGE_SIZE) {
-		ClearPageReserved(virt_to_page(start));
-		init_page_count(virt_to_page(start));
-		free_page(start);
-		totalram_pages_inc();
-	}
-}
-#endif
-
 extern char __init_begin[], __init_end[];
 
 void free_initmem(void)