From: Saravana Kannan <saravanak@google.com>
To: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Jonathan Corbet <corbet@lwn.net>, Len Brown <lenb@kernel.org>
Cc: Saravana Kannan <saravanak@google.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org,
clang-built-linux@googlegroups.com,
David Collins <collinsd@codeaurora.org>,
kernel-team@android.com
Subject: [PATCH v10 7/7] of: property: Add "depends-on" parsing support to of_fwnode_add_links()
Date: Thu, 29 Aug 2019 00:46:03 -0700 [thread overview]
Message-ID: <20190829074603.70424-8-saravanak@google.com> (raw)
In-Reply-To: <20190829074603.70424-1-saravanak@google.com>
If dependencies inferred by of_fwnode_add_links() result in a cycle, it
can prevent the probing of all the devices in the cycle. The depends-on
property has been added to explicitly override inferred dependencies
when they create a cycle.
Add depends-on parsing support to of_fwnode_add_links() so that
platforms with cyclic dependencies can use "depends-on" to break the
cycle and continue successfully probing devices.
Signed-off-by: Saravana Kannan <saravanak@google.com>
---
drivers/of/property.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/of/property.c b/drivers/of/property.c
index 420c2d428184..78a262e24686 100644
--- a/drivers/of/property.c
+++ b/drivers/of/property.c
@@ -1106,6 +1106,12 @@ static struct device_node *parse_interconnects(struct device_node *np,
"#interconnect-cells");
}
+static struct device_node *parse_depends_on(struct device_node *np,
+ const char *prop_name, int index)
+{
+ return parse_prop_cells(np, prop_name, index, "depends-on", NULL);
+}
+
static int strcmp_suffix(const char *str, const char *suffix)
{
unsigned int len, suffix_len;
@@ -1151,6 +1157,7 @@ static const struct supplier_bindings bindings[] = {
{ .parse_prop = parse_clocks, },
{ .parse_prop = parse_interconnects, },
{ .parse_prop = parse_regulators, },
+ { .parse_prop = parse_depends_on, },
{},
};
@@ -1203,6 +1210,12 @@ static int __of_link_to_suppliers(struct device *dev,
struct property *p;
int ret = 0;
+ if (of_find_property(con_np, "depends-on", NULL)) {
+ if (of_link_property(dev, con_np, "depends-on"))
+ ret = -EAGAIN;
+ return ret;
+ }
+
for_each_property_of_node(con_np, p)
if (of_link_property(dev, con_np, p->name))
ret = -EAGAIN;
--
2.23.0.187.g17f5b7556c-goog
next prev parent reply other threads:[~2019-08-29 7:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 7:45 [PATCH v10 0/7] Solve postboot supplier cleanup and optimize probe ordering Saravana Kannan
2019-08-29 7:45 ` [PATCH v10 1/7] driver core: Add support for linking devices during device addition Saravana Kannan
2019-08-29 7:45 ` [PATCH v10 2/7] of: property: Add functional dependency link from DT bindings Saravana Kannan
2019-08-29 16:51 ` Rob Herring
2019-08-29 7:45 ` [PATCH v10 3/7] driver core: Add sync_state driver/bus callback Saravana Kannan
2019-08-29 7:46 ` [PATCH v10 4/7] of/platform: Pause/resume sync state during init and of_platform_populate() Saravana Kannan
2019-08-29 7:46 ` [PATCH v10 5/7] of: property: Create device links for all child-supplier depencencies Saravana Kannan
2019-08-29 7:46 ` [PATCH v10 6/7] dt-bindings: Add depends-on property to break cyclic inferred dependencies Saravana Kannan
2019-08-29 7:46 ` Saravana Kannan [this message]
2019-08-29 16:43 ` [PATCH v10 0/7] Solve postboot supplier cleanup and optimize probe ordering Rob Herring
2019-08-30 4:32 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829074603.70424-8-saravanak@google.com \
--to=saravanak@google.com \
--cc=clang-built-linux@googlegroups.com \
--cc=collinsd@codeaurora.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).