From: Andrew Morton <akpm@linux-foundation.org>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org
Subject: local_softirq_pending()
Date: Wed, 9 Apr 2008 19:27:08 -0700 [thread overview]
Message-ID: <20080409192708.7bdbbe9a.akpm@linux-foundation.org> (raw)
kernel/time/tick-sched.c: In function 'tick_nohz_stop_sched_tick':
kernel/time/tick-sched.c:229: warning: format '%02x' expects type 'unsigned int', but argument 2 has type '__u64'
I don't think the architecture's local_softirq_pending() should return u64.
This is the sort of thing which should be consistent across architectures.
Problem is, we've made such a complete mess of everything that this is a
bitch to fix.
The obvious and moderately clean fix is:
--- a/include/asm-s390/hardirq.h~a
+++ a/include/asm-s390/hardirq.h
@@ -25,10 +25,24 @@ typedef struct {
unsigned int __softirq_pending;
} irq_cpustat_t;
-#define local_softirq_pending() (S390_lowcore.softirq_pending)
+static inline unsigned int local_softirq_pending(void)
+{
+ return S390_lowcore.softirq_pending;
+}
+
+static inline void set_softirq_pending(unsigned int val)
+{
+ S390_lowcore.softirq_pending = val;
+}
+
+static inline void or_softirq_pending(unsigned int val)
+{
+ S390_lowcore.softirq_pending |= val;
+}
#define __ARCH_IRQ_STAT
#define __ARCH_HAS_DO_SOFTIRQ
+#define __ARCH_SET_SOFTIRQ_PENDING
#define HARDIRQ_BITS 8
But that doesn't work because sometimes this 'orrible crap from
linux/interrupt.h:
#ifndef __ARCH_SET_SOFTIRQ_PENDING
#define set_softirq_pending(x) (local_softirq_pending() = (x))
#define or_softirq_pending(x) (local_softirq_pending() |= (x))
#endif
gets included first, which screws up include/asm-s390/hardirq.h.
So I'll cheerfully drop it into someone else's lap. A sensible fix would
be to remove that nonsense from linux/interrupt.h (which appears to have
been added for x86) and give each architecture its own
local_softirq_pending(), set_softirq_pending() and or_softirq_pending().
Very much preferably for avoiding any ^+#define...
btw, there's a naming inconsistency here. Shouldn't they be
local_softirq_pending
set_local_softirq_pending
or_local_softirq_pending
?
btw2, why do we need a per-arch or_softirq_pending()? Can't that just be
built from set_softirq_pending() and local_softirq_pending() in generic code?
next reply other threads:[~2008-04-10 2:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 2:27 Andrew Morton [this message]
2008-04-10 8:08 ` local_softirq_pending() Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080409192708.7bdbbe9a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).