From: yu kuai <yukuai3@huawei.com>
To: <darrick.wong@oracle.com>, <linux-xfs@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <yukuai3@huawei.com>, <zhengbin13@huawei.com>, <yi.zhang@huawei.com>
Subject: [PATCH] xfs: add function name in xfs_trans_ail_delete function header comments
Date: Fri, 30 Aug 2019 18:59:49 +0800 [thread overview]
Message-ID: <1567162789-137056-1-git-send-email-yukuai3@huawei.com> (raw)
Fix following warning:
make W=1 fs/xfs/xfs_trans_ail.o
fs/xfs/xfs_trans_ail.c:793: warning: Function parameter or member
'ailp' not described in 'xfs_trans_ail_delete'
fs/xfs/xfs_trans_ail.c:793: warning: Function parameter or member
'lip' not described in 'xfs_trans_ail_delete'
fs/xfs/xfs_trans_ail.c:793: warning: Function parameter or member
'shutdown_type' not described in 'xfs_trans_ail_delete'
Since function parameters are described in the comments aready,
there is no need to add parameter comments.
Signed-off-by: yu kuai <yukuai3@huawei.com>
---
fs/xfs/xfs_trans_ail.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/xfs/xfs_trans_ail.c b/fs/xfs/xfs_trans_ail.c
index 6ccfd75..b69cf59 100644
--- a/fs/xfs/xfs_trans_ail.c
+++ b/fs/xfs/xfs_trans_ail.c
@@ -764,8 +764,8 @@ xfs_ail_delete_one(
return mlip == lip;
}
-/**
- * Remove a log items from the AIL
+/*
+ * xfs_trans_ail_delete - remove a log items from the AIL
*
* @xfs_trans_ail_delete_bulk takes an array of log items that all need to
* removed from the AIL. The caller is already holding the AIL lock, and done
--
2.7.4
next reply other threads:[~2019-08-30 10:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 10:59 yu kuai [this message]
2019-08-30 15:15 ` [PATCH] xfs: add function name in xfs_trans_ail_delete function header comments Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1567162789-137056-1-git-send-email-yukuai3@huawei.com \
--to=yukuai3@huawei.com \
--cc=darrick.wong@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=yi.zhang@huawei.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).