From: Prarit Bhargava <prarit@redhat.com>
To: platform-driver-x86@vger.kernel.org
Cc: andriy.shevchenko@intel.com, Prarit Bhargava <prarit@redhat.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
David Arcari <darcari@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 7/9] tools/power/x86/intel-speed-select: Output human readable CPU list
Date: Thu, 5 Sep 2019 08:03:09 -0400 [thread overview]
Message-ID: <20190905120311.15286-8-prarit@redhat.com> (raw)
In-Reply-To: <20190905120311.15286-1-prarit@redhat.com>
The intel-speed-select tool currently only outputs a hexidecimal CPU mask,
which requires translation for use with kernel parameters such as
isolcpus.
Along with the CPU mask, output a human readable CPU list.
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: David Arcari <darcari@redhat.com>
Cc: linux-kernel@vger.kernel.org
---
.../x86/intel-speed-select/isst-display.c | 39 +++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/tools/power/x86/intel-speed-select/isst-display.c b/tools/power/x86/intel-speed-select/isst-display.c
index cfeee0beb78d..890a01bfee4b 100644
--- a/tools/power/x86/intel-speed-select/isst-display.c
+++ b/tools/power/x86/intel-speed-select/isst-display.c
@@ -8,6 +8,33 @@
#define DISP_FREQ_MULTIPLIER 100
+static void printcpulist(int str_len, char *str, int mask_size,
+ cpu_set_t *cpu_mask)
+{
+ int i, first, curr_index, index;
+
+ if (!CPU_COUNT_S(mask_size, cpu_mask)) {
+ snprintf(str, str_len, "none");
+ return;
+ }
+
+ curr_index = 0;
+ first = 1;
+ for (i = 0; i < get_topo_max_cpus(); ++i) {
+ if (!CPU_ISSET_S(i, mask_size, cpu_mask))
+ continue;
+ if (!first) {
+ index = snprintf(&str[curr_index],
+ str_len - curr_index, ",");
+ curr_index += index;
+ }
+ index = snprintf(&str[curr_index], str_len - curr_index, "%d",
+ i);
+ curr_index += index;
+ first = 0;
+ }
+}
+
static void printcpumask(int str_len, char *str, int mask_size,
cpu_set_t *cpu_mask)
{
@@ -166,6 +193,12 @@ static void _isst_pbf_display_information(int cpu, FILE *outf, int level,
pbf_info->core_cpumask);
format_and_print(outf, disp_level + 1, header, value);
+ snprintf(header, sizeof(header), "high-priority-cpu-list");
+ printcpulist(sizeof(value), value,
+ pbf_info->core_cpumask_size,
+ pbf_info->core_cpumask);
+ format_and_print(outf, disp_level + 1, header, value);
+
snprintf(header, sizeof(header), "low-priority-base-frequency(MHz)");
snprintf(value, sizeof(value), "%d",
pbf_info->p1_low * DISP_FREQ_MULTIPLIER);
@@ -287,6 +320,12 @@ void isst_ctdp_display_information(int cpu, FILE *outf, int tdp_level,
ctdp_level->core_cpumask);
format_and_print(outf, base_level + 4, header, value);
+ snprintf(header, sizeof(header), "enable-cpu-list");
+ printcpulist(sizeof(value), value,
+ ctdp_level->core_cpumask_size,
+ ctdp_level->core_cpumask);
+ format_and_print(outf, base_level + 4, header, value);
+
snprintf(header, sizeof(header), "thermal-design-power-ratio");
snprintf(value, sizeof(value), "%d", ctdp_level->tdp_ratio);
format_and_print(outf, base_level + 4, header, value);
--
2.21.0
next prev parent reply other threads:[~2019-09-05 12:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 12:03 [PATCH v2 0/9] tools-power-x86-intel-speed-select: Fixes and updates for output Prarit Bhargava
2019-09-05 12:03 ` [PATCH v2 1/9] tools/power/x86/intel-speed-select: Fix package typo Prarit Bhargava
2019-09-05 12:03 ` [PATCH v2 2/9] tools/power/x86/intel-speed-select: Fix help option typo Prarit Bhargava
2019-09-05 12:03 ` [PATCH v2 3/9] tools/power/x86/intel-speed-select: Fix cpu-count output Prarit Bhargava
2019-09-05 12:03 ` [PATCH v2 4/9] tools/power/x86/intel-speed-select: Simplify output for turbo-freq and base-freq Prarit Bhargava
2019-09-05 12:03 ` [PATCH v2 5/9] tools/power/x86/intel-speed-select: Switch output to MHz Prarit Bhargava
2019-09-05 12:03 ` [PATCH v2 6/9] tools/power/x86/intel-speed-select: Change turbo ratio output to maximum turbo frequency Prarit Bhargava
2019-09-05 12:03 ` Prarit Bhargava [this message]
2019-09-05 12:03 ` [PATCH v2 8/9] tools/power/x86/intel-speed-select: Output success/failed for command output Prarit Bhargava
2019-09-05 12:03 ` [PATCH v2 9/9] tools/power/x86/intel-speed-select: Fix memory leak Prarit Bhargava
2019-09-05 19:42 ` Srinivas Pandruvada
2019-09-05 20:56 ` Prarit Bhargava
2019-09-05 21:00 ` Prarit Bhargava
2019-09-05 23:05 ` [PATCH v2 0/9] tools-power-x86-intel-speed-select: Fixes and updates for output Srinivas Pandruvada
2019-09-07 18:13 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905120311.15286-8-prarit@redhat.com \
--to=prarit@redhat.com \
--cc=andriy.shevchenko@intel.com \
--cc=darcari@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).