From: Rob Herring <robh@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Whitcroft <apw@canonical.com>
Subject: [PATCH] checkpatch: Warn if DT bindings are not in schema format
Date: Fri, 13 Sep 2019 16:13:49 -0500 [thread overview]
Message-ID: <20190913211349.28245-1-robh@kernel.org> (raw)
DT bindings are moving to using a json-schema based schema format
instead of freeform text. Add a checkpatch.pl check to encourage using
the schema for new bindings. It's not yet a requirement, but is
progressively being required by some maintainers.
Cc: Andy Whitcroft <apw@canonical.com>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Rob Herring <robh@kernel.org>
---
scripts/checkpatch.pl | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 93a7edfe0f05..1cbd85f16e32 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2822,6 +2822,14 @@ sub process {
"added, moved or deleted file(s), does MAINTAINERS need updating?\n" . $herecurr);
}
+# Check for adding new DT bindings not in schema format
+ if (!$in_commit_log &&
+ ($line =~ /^new file mode\s*\d+\s*$/) &&
+ ($realfile =~ m@^Documentation/devicetree/bindings/.*\.txt$@)) {
+ WARN("DT_SCHEMA_BINDING_PATCH",
+ "DT bindings should be in DT schema format. See: Documentation/devicetree/writing-schema.rst\n");
+ }
+
# Check for wrappage within a valid hunk of the file
if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
ERROR("CORRUPTED_PATCH",
--
2.20.1
next reply other threads:[~2019-09-13 21:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 21:13 Rob Herring [this message]
2019-09-13 21:48 ` [PATCH] checkpatch: Warn if DT bindings are not in schema format Joe Perches
2019-09-16 18:21 ` Rob Herring
2019-09-27 14:02 ` Rob Herring
2019-09-27 14:29 ` Joe Perches
2019-09-27 15:39 ` Rob Herring
2019-10-11 17:56 ` Rob Herring
2019-10-11 18:02 ` Joe Perches
2019-10-11 19:32 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190913211349.28245-1-robh@kernel.org \
--to=robh@kernel.org \
--cc=apw@canonical.com \
--cc=devicetree@vger.kernel.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).