From: "André Almeida" <andrealmeid@collabora.com>
To: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: axboe@kernel.dk, kernel@collabora.com, krisman@collabora.com,
"André Almeida" <andrealmeid@collabora.com>,
"Chaitanya Kulkarni" <chaitanya.kulkarni@wdc.com>
Subject: [PATCH v3 1/3] null_blk: do not fail the module load with zero devices
Date: Mon, 16 Sep 2019 11:07:57 -0300 [thread overview]
Message-ID: <20190916140759.52491-2-andrealmeid@collabora.com> (raw)
In-Reply-To: <20190916140759.52491-1-andrealmeid@collabora.com>
The module load should fail only if there is something wrong with the
configuration or if an error prevents it to work properly. The module
should be able to be loaded with (nr_device == 0), since it will not
trigger errors or be in malfunction state. Preventing loading with zero
devices also breaks applications that configures this module using
configfs API. Remove the nr_device check to fix this.
Fixes: f7c4ce890dd2 ("null_blk: validate the number of devices")
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: André Almeida <andrealmeid@collabora.com>
---
Changes since v2:
- None
Changes since v1:
- None
---
drivers/block/null_blk_main.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/block/null_blk_main.c b/drivers/block/null_blk_main.c
index ab4b87677139..be32cb5ed339 100644
--- a/drivers/block/null_blk_main.c
+++ b/drivers/block/null_blk_main.c
@@ -1758,10 +1758,6 @@ static int __init null_init(void)
pr_err("null_blk: legacy IO path no longer available\n");
return -EINVAL;
}
- if (!nr_devices) {
- pr_err("null_blk: invalid number of devices\n");
- return -EINVAL;
- }
if (g_queue_mode == NULL_Q_MQ && g_use_per_node_hctx) {
if (g_submit_queues != nr_online_nodes) {
pr_warn("null_blk: submit_queues param is set to %u.\n",
--
2.23.0
next prev parent reply other threads:[~2019-09-16 14:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 14:07 [PATCH v3 0/3] null_blk: fixes around nr_devices and log improvements André Almeida
2019-09-16 14:07 ` André Almeida [this message]
2019-09-16 14:07 ` [PATCH v3 2/3] null_blk: match the type of parameter nr_devices André Almeida
2019-09-16 14:07 ` [PATCH v3 3/3] null_blk: format pr_* logs with pr_fmt André Almeida
2019-09-16 14:55 ` [PATCH v3 0/3] null_blk: fixes around nr_devices and log improvements Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190916140759.52491-2-andrealmeid@collabora.com \
--to=andrealmeid@collabora.com \
--cc=axboe@kernel.dk \
--cc=chaitanya.kulkarni@wdc.com \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).