From: Jean-Jacques Hiblot <jjhiblot@ti.com>
To: <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>, <dmurphy@ti.com>
Cc: <tomi.valkeinen@ti.com>, <linux-leds@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Jean-Jacques Hiblot <jjhiblot@ti.com>
Subject: [PATCH v3 2/2] leds: tlc591xx: use devm_led_classdev_register_ext()
Date: Wed, 18 Sep 2019 17:25:56 +0200 [thread overview]
Message-ID: <20190918152556.9925-3-jjhiblot@ti.com> (raw)
In-Reply-To: <20190918152556.9925-1-jjhiblot@ti.com>
Use devm_led_classdev_register_ext() to pass the fwnode to the LED core.
The fwnode can then be used by the firmware core to create meaningful
names.
Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
---
drivers/leds/leds-tlc591xx.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-tlc591xx.c b/drivers/leds/leds-tlc591xx.c
index 3d5a4b92f016..bab792ed59c3 100644
--- a/drivers/leds/leds-tlc591xx.c
+++ b/drivers/leds/leds-tlc591xx.c
@@ -184,6 +184,9 @@ tlc591xx_probe(struct i2c_client *client,
for_each_child_of_node(np, child) {
struct tlc591xx_led *led;
+ struct led_init_data init_data = {};
+
+ init_data.fwnode = of_fwnode_handle(child);
err = of_property_read_u32(child, "reg", ®);
if (err) {
@@ -198,8 +201,6 @@ tlc591xx_probe(struct i2c_client *client,
led = &priv->leds[reg];
led->active = true;
- led->ldev.name =
- of_get_property(child, "label", NULL) ? : child->name;
led->ldev.default_trigger =
of_get_property(child, "linux,default-trigger", NULL);
@@ -207,7 +208,8 @@ tlc591xx_probe(struct i2c_client *client,
led->led_no = reg;
led->ldev.brightness_set_blocking = tlc591xx_brightness_set;
led->ldev.max_brightness = LED_FULL;
- err = devm_led_classdev_register(dev, &led->ldev);
+ err = devm_led_classdev_register_ext(dev, &led->ldev,
+ &init_data);
if (err < 0) {
dev_err(dev, "couldn't register LED %s\n",
led->ldev.name);
--
2.17.1
next prev parent reply other threads:[~2019-09-18 15:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 15:25 [PATCH v3 0/2] leds: tlc591xx: switch to managed LED registration Jean-Jacques Hiblot
2019-09-18 15:25 ` [PATCH v3 1/2] leds: tlc591xx: simplify driver by using the managed led API Jean-Jacques Hiblot
2019-09-19 20:51 ` Jacek Anaszewski
2019-09-26 12:13 ` Pavel Machek
2019-09-18 15:25 ` Jean-Jacques Hiblot [this message]
2019-09-26 12:12 ` [PATCH v3 2/2] leds: tlc591xx: use devm_led_classdev_register_ext() Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190918152556.9925-3-jjhiblot@ti.com \
--to=jjhiblot@ti.com \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).