From: Xiaoming Ni <nixiaoming@huawei.com>
To: <dwmw2@infradead.org>, <dilinger@queued.net>, <richard@nod.at>,
<houtao1@huawei.com>, <viro@zeniv.linux.org.uk>,
<bbrezillon@kernel.org>, <daniel.santos@pobox.com>
Cc: <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<nixiaoming@huawei.com>
Subject: [PATCH] jffs2:freely allocate memory when parameters are invalid
Date: Fri, 20 Sep 2019 14:54:38 +0800 [thread overview]
Message-ID: <1568962478-126260-1-git-send-email-nixiaoming@huawei.com> (raw)
Use kzalloc() to allocate memory in jffs2_fill_super().
Freeing memory when jffs2_parse_options() fails will cause
use-after-free and double-free in jffs2_kill_sb()
Reference: commit 92e2921f7eee6345 ("jffs2: free jffs2_sb_info through
jffs2_kill_sb()")
This makes the code difficult to understand
the code path between memory allocation and free is too long
The reason for this problem is:
Before the jffs2_parse_options() check,
"sb->s_fs_info = c;" has been executed,
so jffs2_sb_info has been assigned to super_block.
we can move "sb->s_fs_info = c;" to the success branch of the
function jffs2_parse_options() and free jffs2_sb_info in the failure branch
make the code easier to understand.
Signed-off-by: Xiaoming Ni <nixiaoming@huawei.com>
---
fs/jffs2/super.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/jffs2/super.c b/fs/jffs2/super.c
index af4aa65..bbdae72 100644
--- a/fs/jffs2/super.c
+++ b/fs/jffs2/super.c
@@ -280,11 +280,13 @@ static int jffs2_fill_super(struct super_block *sb, void *data, int silent)
c->mtd = sb->s_mtd;
c->os_priv = sb;
- sb->s_fs_info = c;
ret = jffs2_parse_options(c, data);
- if (ret)
+ if (ret) {
+ kfree(c);
return -EINVAL;
+ }
+ sb->s_fs_info = c;
/* Initialize JFFS2 superblock locks, the further initialization will
* be done later */
--
1.8.5.6
next reply other threads:[~2019-09-20 6:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 6:54 Xiaoming Ni [this message]
2019-09-20 11:43 ` [PATCH] jffs2:freely allocate memory when parameters are invalid Al Viro
2019-09-20 12:21 ` Xiaoming Ni
2019-09-20 12:45 ` Al Viro
2019-09-20 12:54 ` Al Viro
2019-09-20 14:13 ` Xiaoming Ni
2019-09-20 14:38 ` Richard Weinberger
2019-09-21 1:24 ` Hou Tao
2019-09-21 15:37 ` Richard Weinberger
2019-09-20 15:28 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1568962478-126260-1-git-send-email-nixiaoming@huawei.com \
--to=nixiaoming@huawei.com \
--cc=bbrezillon@kernel.org \
--cc=daniel.santos@pobox.com \
--cc=dilinger@queued.net \
--cc=dwmw2@infradead.org \
--cc=houtao1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).