From: Markus Elfring <Markus.Elfring@web.de>
To: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Pawel Dembicki <paweldembicki@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 2/2] net: dsa: vsc73xx: Return an error code as a constant in vsc73xx_platform_probe()
Date: Fri, 20 Sep 2019 16:30:13 +0200 [thread overview]
Message-ID: <738c12c8-f51e-d2e5-f31e-7f726cf6325d@web.de> (raw)
In-Reply-To: <98fee5f4-1e45-a0c6-2a38-9201b201c6eb@web.de>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 20 Sep 2019 16:07:07 +0200
* Return an error code without storing it in an intermediate variable.
* Delete the local variable “ret” which became unnecessary
with this refactoring.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/net/dsa/vitesse-vsc73xx-platform.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/dsa/vitesse-vsc73xx-platform.c b/drivers/net/dsa/vitesse-vsc73xx-platform.c
index a3bbf9bd1bf1..0ae8d904ca85 100644
--- a/drivers/net/dsa/vitesse-vsc73xx-platform.c
+++ b/drivers/net/dsa/vitesse-vsc73xx-platform.c
@@ -89,7 +89,6 @@ static int vsc73xx_platform_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct vsc73xx_platform *vsc_platform;
- int ret;
vsc_platform = devm_kzalloc(dev, sizeof(*vsc_platform), GFP_KERNEL);
if (!vsc_platform)
@@ -103,8 +102,7 @@ static int vsc73xx_platform_probe(struct platform_device *pdev)
vsc_platform->base_addr = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(vsc_platform->base_addr)) {
dev_err(&pdev->dev, "cannot request I/O memory space\n");
- ret = -ENXIO;
- return ret;
+ return -ENXIO;
}
return vsc73xx_probe(&vsc_platform->vsc);
--
2.23.0
next prev parent reply other threads:[~2019-09-20 14:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 14:25 [PATCH 0/2] net: dsa: vsc73xx: Adjustments for vsc73xx_platform_probe() Markus Elfring
2019-09-20 14:28 ` [PATCH 1/2] net: dsa: vsc73xx: Use devm_platform_ioremap_resource() in vsc73xx_platform_probe() Markus Elfring
2019-09-20 15:08 ` Andrew Lunn
2019-09-20 14:30 ` Markus Elfring [this message]
2019-09-20 15:08 ` [PATCH 2/2] net: dsa: vsc73xx: Return an error code as a constant " Andrew Lunn
2019-09-20 15:09 ` [PATCH 0/2] net: dsa: vsc73xx: Adjustments for vsc73xx_platform_probe() Andrew Lunn
2019-09-20 15:30 ` [0/2] " Markus Elfring
2019-09-20 16:36 ` Florian Fainelli
2019-09-20 22:12 ` Jakub Kicinski
2019-09-21 7:12 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=738c12c8-f51e-d2e5-f31e-7f726cf6325d@web.de \
--to=markus.elfring@web.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paweldembicki@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).