From: Benoit Parrot <bparrot@ti.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Prabhakar Lad <prabhakar.csengg@gmail.com>,
<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Benoit Parrot <bparrot@ti.com>
Subject: [Patch v3 05/13] media: am437x-vpfe: fix start streaming error path
Date: Fri, 20 Sep 2019 12:05:46 -0500 [thread overview]
Message-ID: <20190920170554.29666-6-bparrot@ti.com> (raw)
In-Reply-To: <20190920170554.29666-1-bparrot@ti.com>
When start_streaming fails the h/w module might be left enabled
inadvertently. Make sure it is disabled in the error path.
Signed-off-by: Benoit Parrot <bparrot@ti.com>
---
drivers/media/platform/am437x/am437x-vpfe.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/am437x/am437x-vpfe.c b/drivers/media/platform/am437x/am437x-vpfe.c
index 66df87d310a2..e0a4c8920df8 100644
--- a/drivers/media/platform/am437x/am437x-vpfe.c
+++ b/drivers/media/platform/am437x/am437x-vpfe.c
@@ -2008,6 +2008,7 @@ static int vpfe_start_streaming(struct vb2_queue *vq, unsigned int count)
vb2_buffer_done(&buf->vb.vb2_buf, VB2_BUF_STATE_QUEUED);
}
+ vpfe_pcr_enable(&vpfe->ccdc, 0);
return ret;
}
--
2.17.1
next prev parent reply other threads:[~2019-09-20 17:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 17:05 [Patch v3 00/13] media: am437x-vpfe: overdue maintenance Benoit Parrot
2019-09-20 17:05 ` [Patch v3 01/13] media: am437x-vpfe: Fix suspend path to always handle pinctrl config Benoit Parrot
2019-09-20 17:05 ` [Patch v3 02/13] media: am437x-vpfe: Fix missing first line Benoit Parrot
2019-09-20 17:05 ` [Patch v3 03/13] media: am437x-vpfe: Rework ISR routine for clarity Benoit Parrot
2019-09-20 17:05 ` [Patch v3 04/13] media: am437x-vpfe: Wait for end of frame before tear-down Benoit Parrot
2019-09-20 17:05 ` Benoit Parrot [this message]
2019-09-20 17:05 ` [Patch v3 06/13] media: am437x-vpfe: Streamlined vb2 buffer cleanup Benoit Parrot
2019-09-20 17:05 ` [Patch v3 07/13] media: am437x-vpfe: Setting STD to current value is not an error Benoit Parrot
2019-09-20 17:05 ` [Patch v3 08/13] media: am437x-vpfe: Use a per instance format array instead of a static one Benoit Parrot
2019-09-20 17:05 ` [Patch v3 09/13] media: am437x-vpfe: fix function trace debug log Benoit Parrot
2019-09-20 17:05 ` [Patch v3 10/13] media: am437x-vpfe: TRY_FMT ioctl is not really trying anything Benoit Parrot
2019-09-20 17:05 ` [Patch v3 11/13] media: am437x-vpfe: Remove per bus width static data Benoit Parrot
2019-09-20 17:05 ` [Patch v3 12/13] media: am437x-vpfe: Switch to SPDX Licensing Benoit Parrot
2019-09-20 17:05 ` [Patch v3 13/13] media: am437x-vpfe: Remove print_fourcc helper Benoit Parrot
2019-09-22 18:08 ` [Patch v3 00/13] media: am437x-vpfe: overdue maintenance Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190920170554.29666-6-bparrot@ti.com \
--to=bparrot@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).