From: Benoit Parrot <bparrot@ti.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Prabhakar Lad <prabhakar.csengg@gmail.com>,
<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Benoit Parrot <bparrot@ti.com>
Subject: [Patch v3 07/13] media: am437x-vpfe: Setting STD to current value is not an error
Date: Fri, 20 Sep 2019 12:05:48 -0500 [thread overview]
Message-ID: <20190920170554.29666-8-bparrot@ti.com> (raw)
In-Reply-To: <20190920170554.29666-1-bparrot@ti.com>
VIDIOC_S_STD should not return an error if the value is identical
to the current one.
This error was highlighted by the v4l2-compliance test.
Signed-off-by: Benoit Parrot <bparrot@ti.com>
---
drivers/media/platform/am437x/am437x-vpfe.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/media/platform/am437x/am437x-vpfe.c b/drivers/media/platform/am437x/am437x-vpfe.c
index 03415c179c85..8b218f48428f 100644
--- a/drivers/media/platform/am437x/am437x-vpfe.c
+++ b/drivers/media/platform/am437x/am437x-vpfe.c
@@ -1822,6 +1822,10 @@ static int vpfe_s_std(struct file *file, void *priv, v4l2_std_id std_id)
if (!(sdinfo->inputs[0].capabilities & V4L2_IN_CAP_STD))
return -ENODATA;
+ /* if trying to set the same std then nothing to do */
+ if (vpfe_standards[vpfe->std_index].std_id == std_id)
+ return 0;
+
/* If streaming is started, return error */
if (vb2_is_busy(&vpfe->buffer_queue)) {
vpfe_err(vpfe, "%s device busy\n", __func__);
--
2.17.1
next prev parent reply other threads:[~2019-09-20 17:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 17:05 [Patch v3 00/13] media: am437x-vpfe: overdue maintenance Benoit Parrot
2019-09-20 17:05 ` [Patch v3 01/13] media: am437x-vpfe: Fix suspend path to always handle pinctrl config Benoit Parrot
2019-09-20 17:05 ` [Patch v3 02/13] media: am437x-vpfe: Fix missing first line Benoit Parrot
2019-09-20 17:05 ` [Patch v3 03/13] media: am437x-vpfe: Rework ISR routine for clarity Benoit Parrot
2019-09-20 17:05 ` [Patch v3 04/13] media: am437x-vpfe: Wait for end of frame before tear-down Benoit Parrot
2019-09-20 17:05 ` [Patch v3 05/13] media: am437x-vpfe: fix start streaming error path Benoit Parrot
2019-09-20 17:05 ` [Patch v3 06/13] media: am437x-vpfe: Streamlined vb2 buffer cleanup Benoit Parrot
2019-09-20 17:05 ` Benoit Parrot [this message]
2019-09-20 17:05 ` [Patch v3 08/13] media: am437x-vpfe: Use a per instance format array instead of a static one Benoit Parrot
2019-09-20 17:05 ` [Patch v3 09/13] media: am437x-vpfe: fix function trace debug log Benoit Parrot
2019-09-20 17:05 ` [Patch v3 10/13] media: am437x-vpfe: TRY_FMT ioctl is not really trying anything Benoit Parrot
2019-09-20 17:05 ` [Patch v3 11/13] media: am437x-vpfe: Remove per bus width static data Benoit Parrot
2019-09-20 17:05 ` [Patch v3 12/13] media: am437x-vpfe: Switch to SPDX Licensing Benoit Parrot
2019-09-20 17:05 ` [Patch v3 13/13] media: am437x-vpfe: Remove print_fourcc helper Benoit Parrot
2019-09-22 18:08 ` [Patch v3 00/13] media: am437x-vpfe: overdue maintenance Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190920170554.29666-8-bparrot@ti.com \
--to=bparrot@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).