linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: vincenzo.frascino@arm.com, ard.biesheuvel@linaro.org,
	ndesaulniers@google.com, catalin.marinas@arm.com,
	will@kernel.org, tglx@linutronix.de
Subject: [PATCH v3 3/5] arm64: vdso32: Fix compilation warning
Date: Thu, 26 Sep 2019 22:43:40 +0100	[thread overview]
Message-ID: <20190926214342.34608-4-vincenzo.frascino@arm.com> (raw)
In-Reply-To: <20190926214342.34608-1-vincenzo.frascino@arm.com>

As reported by Will Deacon the following compilation warning appears
during the compilation of the vdso32:

In file included from ./arch/arm64/include/asm/thread_info.h:17:0,
                 from ./include/linux/thread_info.h:38,
                 from ./arch/arm64/include/asm/preempt.h:5,
                 from ./include/linux/preempt.h:78,
                 from ./include/linux/spinlock.h:51,
                 from ./include/linux/seqlock.h:36,
                 from ./include/linux/time.h:6,
                 from .../work/linux/lib/vdso/gettimeofday.c:7,
                 from <command-line>:0:
./arch/arm64/include/asm/memory.h: In function ‘__tag_set’:
./arch/arm64/include/asm/memory.h:233:15: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
  u64 __addr = (u64)addr & ~__tag_shifted(0xff);
               ^
In file included from ./arch/arm64/include/asm/pgtable-hwdef.h:8:0,
                 from ./arch/arm64/include/asm/processor.h:34,
                 from ./arch/arm64/include/asm/elf.h:118,
                 from ./include/linux/elf.h:5,
                 from ./include/linux/elfnote.h:62,
                 from arch/arm64/kernel/vdso32/note.c:11:
./arch/arm64/include/asm/memory.h: In function ‘__tag_set’:
./arch/arm64/include/asm/memory.h:233:15: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
  u64 __addr = (u64)addr & ~__tag_shifted(0xff);
               ^

This happens because few 64 bit compilation headers are included during
the generation of vdso32.

Fix the issue redefining the __tag_set function.

Note: This fix is meant to be temporary, a more comprehensive solution
based on the refactoring of the generic headers will be provided with a
future patch set. At that point it will be possible to revert this patch.

Cc: Will Deacon <will@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
---
 arch/arm64/include/asm/memory.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h
index b61b50bf68b1..c61b2eb50a3b 100644
--- a/arch/arm64/include/asm/memory.h
+++ b/arch/arm64/include/asm/memory.h
@@ -228,11 +228,14 @@ static inline unsigned long kaslr_offset(void)
 #define __tag_get(addr)		0
 #endif /* CONFIG_KASAN_SW_TAGS */
 
+#ifdef __aarch64__
+/* Do not attempt to compile this code with compat vdso */
 static inline const void *__tag_set(const void *addr, u8 tag)
 {
 	u64 __addr = (u64)addr & ~__tag_shifted(0xff);
 	return (const void *)(__addr | __tag_shifted(tag));
 }
+#endif
 
 /*
  * Physical vs virtual RAM address space conversion.  These are
-- 
2.23.0


  parent reply	other threads:[~2019-09-26 21:44 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-20 14:27 Problems with arm64 compat vdso Will Deacon
2019-09-20 16:33 ` Vincenzo Frascino
2019-09-23 16:41   ` Ard Biesheuvel
2019-09-24 12:11     ` Vincenzo Frascino
2019-09-24 18:06       ` Nick Desaulniers
2019-09-24 20:42         ` Vincenzo Frascino
2019-09-25 15:58     ` Ard Biesheuvel
2019-09-26  6:03 ` [PATCH 0/4] arm64: vdso32: Address various issues Vincenzo Frascino
2019-09-26  6:03   ` [PATCH 1/4] arm64: vdso32: Introduce COMPAT_CC_IS_GCC Vincenzo Frascino
2019-09-26  8:06     ` Catalin Marinas
2019-09-26 10:56       ` Vincenzo Frascino
2019-09-26 11:02         ` Vincenzo Frascino
2019-09-26 15:23           ` Catalin Marinas
2019-09-26 12:22         ` Vincenzo Frascino
2019-09-26 15:17           ` Catalin Marinas
2019-09-26 20:17             ` Vincenzo Frascino
2019-09-26  6:03   ` [PATCH 2/4] arm64: vdso32: Detect binutils support for dmb ishld Vincenzo Frascino
2019-09-26  8:30     ` Catalin Marinas
2019-09-26 10:59       ` Vincenzo Frascino
2019-09-26  6:03   ` [PATCH 3/4] arm64: vdso32: Fix compilation warning Vincenzo Frascino
2019-09-26  8:32     ` Catalin Marinas
2019-09-26 11:03       ` Vincenzo Frascino
2019-09-26  6:03   ` [PATCH 4/4] arm64: Remove gettimeofday.S Vincenzo Frascino
2019-09-26  8:34     ` Catalin Marinas
2019-09-26 13:38 ` [PATCH v2 0/4] arm64: vdso32: Address various issues Vincenzo Frascino
2019-09-26 13:38   ` [PATCH v2 1/4] arm64: vdso32: Introduce COMPAT_CC_IS_GCC Vincenzo Frascino
2019-09-26 15:13     ` Catalin Marinas
2019-09-26 13:38   ` [PATCH v2 2/4] arm64: vdso32: Detect binutils support for dmb ishld Vincenzo Frascino
2019-09-26 14:26     ` Catalin Marinas
2019-09-26 20:19       ` Vincenzo Frascino
2019-09-26 15:59     ` Catalin Marinas
2019-09-26 21:17       ` Vincenzo Frascino
2019-09-26 16:23     ` Nick Desaulniers
2019-09-26 13:38   ` [PATCH v2 3/4] arm64: vdso32: Fix compilation warning Vincenzo Frascino
2019-09-26 15:22     ` Catalin Marinas
2019-09-26 13:38   ` [PATCH v2 4/4] arm64: Remove gettimeofday.S Vincenzo Frascino
2019-09-26 15:31   ` [PATCH v2 0/4] arm64: vdso32: Address various issues Catalin Marinas
2019-09-26 20:29     ` Vincenzo Frascino
2019-09-26 21:43 ` [PATCH v3 0/5]arm64: " Vincenzo Frascino
2019-09-26 21:43   ` [PATCH v3 1/5] arm64: vdso32: Introduce COMPAT_CC_IS_GCC Vincenzo Frascino
2019-09-27  9:24     ` Catalin Marinas
2019-10-01 13:14     ` Will Deacon
2019-10-01 13:27       ` Catalin Marinas
2019-10-01 14:20         ` Vincenzo Frascino
2019-10-01 14:20           ` Will Deacon
2019-10-01 14:37             ` Vincenzo Frascino
2019-10-01 14:43               ` Will Deacon
2019-10-01 14:59                 ` Vincenzo Frascino
2019-10-01 15:30                 ` Catalin Marinas
2019-10-01 16:46                   ` Will Deacon
2019-10-01 16:59                     ` Nick Desaulniers
2019-10-01 17:07                       ` Will Deacon
2019-10-01 17:12                         ` Nick Desaulniers
2019-10-01 17:14                           ` Will Deacon
2019-09-26 21:43   ` [PATCH v3 2/5] arm64: vdso32: Detect binutils support for dmb ishld Vincenzo Frascino
2019-09-27  9:25     ` Catalin Marinas
2019-10-01 13:26     ` Will Deacon
2019-10-01 14:23       ` Vincenzo Frascino
2019-09-26 21:43   ` Vincenzo Frascino [this message]
2019-09-27  9:26     ` [PATCH v3 3/5] arm64: vdso32: Fix compilation warning Catalin Marinas
2019-10-01 13:21     ` Will Deacon
2019-10-01 14:41       ` Vincenzo Frascino
2019-09-26 21:43   ` [PATCH v3 4/5] arm64: Remove gettimeofday.S Vincenzo Frascino
2019-09-26 21:43   ` [PATCH v3 5/5] arm64: vdso32: Remove jump label config option in Makefile Vincenzo Frascino
2019-09-27  9:27     ` Catalin Marinas
2019-09-27 10:46   ` [PATCH v3 0/5]arm64: vdso32: Address various issues Catalin Marinas
2019-10-01 13:27   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190926214342.34608-4-vincenzo.frascino@arm.com \
    --to=vincenzo.frascino@arm.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).