From: Benoit Parrot <bparrot@ti.com>
To: Hans Verkuil <hverkuil@xs4all.nl>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Benoit Parrot <bparrot@ti.com>
Subject: [Patch v5 7/8] media: i2c: ov2659: Fix missing 720p register config
Date: Mon, 30 Sep 2019 08:06:43 -0500 [thread overview]
Message-ID: <20190930130644.8704-8-bparrot@ti.com> (raw)
In-Reply-To: <20190930130644.8704-1-bparrot@ti.com>
The initial registers sequence is only loaded at probe
time. Afterward only the resolution and format specific
register are modified. Care must be taken to make sure
registers modified by one resolution setting are reverted
back when another resolution is programmed.
This was not done properly for the 720p case.
Signed-off-by: Benoit Parrot <bparrot@ti.com>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
drivers/media/i2c/ov2659.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
index 80de2e35aeca..c1e2aa1f952d 100644
--- a/drivers/media/i2c/ov2659.c
+++ b/drivers/media/i2c/ov2659.c
@@ -411,10 +411,14 @@ static struct sensor_register ov2659_720p[] = {
{ REG_TIMING_YINC, 0x11 },
{ REG_TIMING_VERT_FORMAT, 0x80 },
{ REG_TIMING_HORIZ_FORMAT, 0x00 },
+ { 0x370a, 0x12 },
{ 0x3a03, 0xe8 },
{ 0x3a09, 0x6f },
{ 0x3a0b, 0x5d },
{ 0x3a15, 0x9a },
+ { REG_VFIFO_READ_START_H, 0x00 },
+ { REG_VFIFO_READ_START_L, 0x80 },
+ { REG_ISP_CTRL02, 0x00 },
{ REG_NULL, 0x00 },
};
--
2.17.1
next prev parent reply other threads:[~2019-09-30 13:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 13:06 [Patch v5 0/8] media: i2c: ov2659: maintenance series Benoit Parrot
2019-09-30 13:06 ` [Patch v5 1/8] media: i2c: ov2659: Fix for image wrap-around in lower resolution Benoit Parrot
2019-09-30 13:06 ` [Patch v5 2/8] media: i2c: ov2659: Fix sensor detection to actually fail when device is not present Benoit Parrot
2019-09-30 13:06 ` [Patch v5 3/8] media: i2c: ov2659: Cleanup include file list Benoit Parrot
2019-09-30 13:06 ` [Patch v5 4/8] media: i2c: ov2659: fix s_stream return value Benoit Parrot
2019-10-01 6:04 ` Lad, Prabhakar
2019-09-30 13:06 ` [Patch v5 5/8] media: dt-bindings: ov2659: add powerdown/reset-gpios optional property Benoit Parrot
2019-09-30 13:06 ` [Patch v5 6/8] media: i2c: ov2659: Add powerdown/reset gpio handling Benoit Parrot
2019-10-01 6:03 ` Lad, Prabhakar
2019-09-30 13:06 ` Benoit Parrot [this message]
2019-09-30 13:06 ` [Patch v5 8/8] media: i2c: ov2659: Switch to SPDX Licensing Benoit Parrot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930130644.8704-8-bparrot@ti.com \
--to=bparrot@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).