From: Johan Hovold <johan@kernel.org>
To: Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
"Johan Hovold" <johan@kernel.org>,
stable <stable@vger.kernel.org>,
"Remigiusz Kołłątaj" <remigiusz.kollataj@mobica.com>,
syzbot+e29b17e5042bbc56fae9@syzkaller.appspotmail.com
Subject: [PATCH 1/2] can: mcba_usb: fix use-after-free on disconnect
Date: Tue, 1 Oct 2019 12:29:13 +0200 [thread overview]
Message-ID: <20191001102914.4567-2-johan@kernel.org> (raw)
In-Reply-To: <20191001102914.4567-1-johan@kernel.org>
The driver was accessing its driver data after having freed it.
Fixes: 51f3baad7de9 ("can: mcba_usb: Add support for Microchip CAN BUS Analyzer")
Cc: stable <stable@vger.kernel.org> # 4.12
Cc: Remigiusz Kołłątaj <remigiusz.kollataj@mobica.com>
Reported-by: syzbot+e29b17e5042bbc56fae9@syzkaller.appspotmail.com
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/net/can/usb/mcba_usb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/can/usb/mcba_usb.c b/drivers/net/can/usb/mcba_usb.c
index 19a702ac49e4..21faa2ec4632 100644
--- a/drivers/net/can/usb/mcba_usb.c
+++ b/drivers/net/can/usb/mcba_usb.c
@@ -876,9 +876,8 @@ static void mcba_usb_disconnect(struct usb_interface *intf)
netdev_info(priv->netdev, "device disconnected\n");
unregister_candev(priv->netdev);
- free_candev(priv->netdev);
-
mcba_urb_unlink(priv);
+ free_candev(priv->netdev);
}
static struct usb_driver mcba_usb_driver = {
--
2.23.0
next prev parent reply other threads:[~2019-10-01 10:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 10:29 [PATCH 0/2] can: fix use-after-free on USB disconnect Johan Hovold
2019-10-01 10:29 ` Johan Hovold [this message]
2019-10-01 10:29 ` [PATCH 2/2] can: usb_8dev: fix use-after-free on disconnect Johan Hovold
2019-10-04 20:45 ` [PATCH 0/2] can: fix use-after-free on USB disconnect Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001102914.4567-2-johan@kernel.org \
--to=johan@kernel.org \
--cc=davem@davemloft.net \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=remigiusz.kollataj@mobica.com \
--cc=stable@vger.kernel.org \
--cc=syzbot+e29b17e5042bbc56fae9@syzkaller.appspotmail.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).