From: Markus Elfring <Markus.Elfring@web.de>
To: Gilles Muller <Gilles.Muller@lip6.fr>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jessica Yu <jeyu@kernel.org>, Julia Lawall <julia.lawall@lip6.fr>,
Martijn Coenen <maco@android.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Matthias Maennich <maennich@google.com>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>,
Yue Haibing <yuehaibing@huawei.com>,
Coccinelle <cocci@systeme.lip6.fr>,
kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/2] Coccinelle: Move the SmPL script “add_namespace.cocci” into a new directory
Date: Wed, 2 Oct 2019 09:10:55 +0200 [thread overview]
Message-ID: <2b4e3866-d0fc-e6ca-9977-777b2a0cfc0e@web.de> (raw)
In-Reply-To: <d8c97f0a-6ce2-0f5a-74a9-63366c17f3a6@web.de>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 1 Oct 2019 20:56:45 +0200
The script “add_namespace.cocci” was integrated into a known directory
without taking all relevant system dependencies into account
(despite of positive code review feedback).
See also:
* Commit eb8305aecb958e8787e7d603c7765c1dcace3a2b ("scripts: Coccinelle script for namespace dependencies.")
* Topic “[Cocci] [RFC PATCH] scripts: Fix coccicheck failed”
https://lore.kernel.org/cocci/20191001125742.GD90796@google.com/
https://systeme.lip6.fr/pipermail/cocci/2019-October/006351.html
https://lkml.org/lkml/2019/10/1/503
YueHaibing reported then that the standard system configuration
did not work any more as it was expected for the tool “coccicheck”.
https://lore.kernel.org/cocci/20190928094245.45696-1-yuehaibing@huawei.com/
https://systeme.lip6.fr/pipermail/cocci/2019-September/006341.html
https://lkml.org/lkml/2019/9/28/29
The added SmPL script was designed in the way that no corresponding
operation modes were supported so far.
This approach can also work finally if additional script execution
criteria will be taken into account.
Thus move it into a directory which will not be directly included
by the filter command of the tool “coccicheck”.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
scripts/coccinelle/{misc => direct}/add_namespace.cocci | 0
scripts/nsdeps | 2 +-
2 files changed, 1 insertion(+), 1 deletion(-)
rename scripts/coccinelle/{misc => direct}/add_namespace.cocci (100%)
diff --git a/scripts/coccinelle/misc/add_namespace.cocci b/scripts/coccinelle/direct/add_namespace.cocci
similarity index 100%
rename from scripts/coccinelle/misc/add_namespace.cocci
rename to scripts/coccinelle/direct/add_namespace.cocci
diff --git a/scripts/nsdeps b/scripts/nsdeps
index ac2b6031dd13..9000524f9347 100644
--- a/scripts/nsdeps
+++ b/scripts/nsdeps
@@ -23,7 +23,7 @@ fi
generate_deps_for_ns() {
$SPATCH --very-quiet --in-place --sp-file \
- $srctree/scripts/coccinelle/misc/add_namespace.cocci -D ns=$1 $2
+ $srctree/scripts/coccinelle/direct/add_namespace.cocci -D ns=$1 $2
}
generate_deps() {
--
2.23.0
next prev parent reply other threads:[~2019-10-02 7:11 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-28 9:42 [RFC PATCH] scripts: Fix coccicheck failed YueHaibing
2019-09-28 12:43 ` Julia Lawall
2019-09-29 2:04 ` Yuehaibing
2019-09-29 16:32 ` Julia Lawall
2019-09-29 18:00 ` [Cocci] " Markus Elfring
2019-09-29 18:05 ` Julia Lawall
2019-09-29 18:18 ` [Cocci] [RFC] " Markus Elfring
2019-09-30 2:32 ` [RFC PATCH] " Yuehaibing
2019-10-01 12:57 ` Matthias Maennich
2019-10-01 15:33 ` [Cocci] [RFC] " Markus Elfring
2019-10-01 13:01 ` [RFC PATCH] " Julia Lawall
2019-10-03 11:57 ` Masahiro Yamada
2019-10-03 12:22 ` Julia Lawall
2019-10-04 2:32 ` Masahiro Yamada
2019-10-05 11:17 ` [Cocci] [RFC] " Markus Elfring
2019-10-05 12:26 ` Julia Lawall
2019-10-05 17:49 ` Markus Elfring
2019-10-05 17:49 ` Markus Elfring
2019-10-06 5:21 ` Markus Elfring
2019-10-06 5:28 ` Julia Lawall
2019-10-06 5:34 ` Markus Elfring
2019-10-06 7:30 ` Greg Kroah-Hartman
2019-10-06 4:23 ` [RFC PATCH] " Yuehaibing
2019-10-06 4:44 ` [PATCH] scripts: add_namespace: " YueHaibing
2019-10-06 6:40 ` Markus Elfring
2019-10-06 6:44 ` Julia Lawall
2019-10-06 7:00 ` Markus Elfring
2019-10-06 11:09 ` [PATCH] " Matthias Maennich
2019-10-07 13:15 ` Jessica Yu
2019-10-03 16:30 ` [Cocci] [RFC] scripts: " Markus Elfring
2019-10-03 16:30 ` Markus Elfring
2019-10-03 19:35 ` Julia Lawall
2019-10-04 8:23 ` Markus Elfring
2019-09-29 8:20 ` [Cocci] [RFC PATCH] " Markus Elfring
2019-09-29 13:12 ` Markus Elfring
2019-09-29 16:40 ` Julia Lawall
2019-10-02 7:09 ` [PATCH 0/2] Coccinelle: Extend directory hierarchy Markus Elfring
2019-10-02 7:10 ` Markus Elfring [this message]
2019-10-02 7:12 ` [PATCH 2/2] Coccinelle: Move coccicheck directories into a new subdirectory Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b4e3866-d0fc-e6ca-9977-777b2a0cfc0e@web.de \
--to=markus.elfring@web.de \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=gregkh@linuxfoundation.org \
--cc=jeyu@kernel.org \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=maennich@google.com \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=yamada.masahiro@socionext.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).