From: <Narendra.K@dell.com>
To: <linux-efi@vger.kernel.org>
Cc: <Mario.Limonciello@dell.com>, <ard.biesheuvel@linaro.org>,
<geert@linux-m68k.org>, <tglx@linutronix.de>,
<linux-kernel@vger.kernel.org>, <james.morse@arm.com>,
<mingo@kernel.org>, <Narendra.K@dell.com>
Subject: [PATCH] Ask user input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y
Date: Wed, 2 Oct 2019 19:44:00 +0000 [thread overview]
Message-ID: <20191002194346.GA3792@localhost.localdomain> (raw)
From: Narendra K <Narendra.K@dell.com>
For the EFI_RCI2_TABLE kconfig option, 'make oldconfig' asks the user
for input as it is a new kconfig option in kernel version 5.4. This patch
modifies the kconfig option to ask the user for input only when CONFIG_X86
or CONFIG_COMPILE_TEST is set to y.
The patch also makes EFI_RCI2_TABLE kconfig option depend on CONFIG_EFI.
Signed-off-by: Narendra K <Narendra.K@dell.com>
---
The patch is created on kernel version 5.4-rc1.
Hi Ard, I have made following changes -
- changed the prompt string from "EFI Runtime Configuration
Interface Table Version 2 Support" to "EFI RCI Table Version 2 Support"
as the string crossed 80 char limit.
- added "depends on EFI" so that code builds only when CONFIG_EFI is
set to y.
- added 'default n' for ease of understanding though default is set to n.
drivers/firmware/efi/Kconfig | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
index 178ee8106828..6e4c46e8a954 100644
--- a/drivers/firmware/efi/Kconfig
+++ b/drivers/firmware/efi/Kconfig
@@ -181,7 +181,10 @@ config RESET_ATTACK_MITIGATION
reboots.
config EFI_RCI2_TABLE
- bool "EFI Runtime Configuration Interface Table Version 2 Support"
+ bool
+ prompt "EFI RCI Table Version 2 Support" if X86 || COMPILE_TEST
+ depends on EFI
+ default n
help
Displays the content of the Runtime Configuration Interface
Table version 2 on Dell EMC PowerEdge systems as a binary
--
2.18.1
--
With regards,
Narendra K
next reply other threads:[~2019-10-02 19:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 19:44 Narendra.K [this message]
2019-10-09 14:11 ` [PATCH] Ask user input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y Ard Biesheuvel
2019-10-10 17:47 ` Narendra.K
2019-10-10 18:50 ` Geert Uytterhoeven
2019-10-11 9:43 ` Narendra.K
2019-10-11 10:01 ` Geert Uytterhoeven
2019-10-11 12:55 ` Narendra.K
2019-10-12 17:04 ` Geert Uytterhoeven
2019-10-13 19:08 ` Narendra.K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191002194346.GA3792@localhost.localdomain \
--to=narendra.k@dell.com \
--cc=Mario.Limonciello@dell.com \
--cc=ard.biesheuvel@linaro.org \
--cc=geert@linux-m68k.org \
--cc=james.morse@arm.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).